Improve warning regarding movementX and movementY #31651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs External URLs (2)URL:
URL:
(comment last updated: 2024-01-11 07:09:18) |
bsmth
approved these changes
Jan 15, 2024
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
* Improve warning regarding movementX and movementY * improve the warning for movementY as well * update movementX warning to ref screen* values * update movementY to ref screen* values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Using movementX in a cross-browser setting is not going to work well. Suggest for people to calculate the delta themselves using client values.
Additional details
Related issues and pull requests