Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make property attributes of getter, setter, method syntax explicit #30947

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #29489

@Josh-Cena Josh-Cena requested a review from a team as a code owner December 12, 2023 08:13
@Josh-Cena Josh-Cena requested review from chrisdavidmills and removed request for a team December 12, 2023 08:13
@github-actions github-actions bot added the Content:JS JavaScript docs label Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Josh-Cena! Just a small wording tweak request to look at.

Co-authored-by: Chris Mills <[email protected]>
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks again @Josh-Cena! Let's get this merged.

@chrisdavidmills chrisdavidmills merged commit 530c492 into mdn:main Jan 15, 2024
7 checks passed
@Josh-Cena Josh-Cena deleted the property-desc-syntax branch January 15, 2024 15:31
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
…dn#30947)

* Make property attributes of getter, setter, method syntax explicit

* Update index.md

Co-authored-by: Chris Mills <[email protected]>

---------

Co-authored-by: Chris Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include information/section on "Method definitions in object literals"
2 participants