Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentious/image background fix #29754

Closed
wants to merge 5 commits into from
Closed

Sentious/image background fix #29754

wants to merge 5 commits into from

Conversation

Sentious
Copy link
Contributor

Description

  • Changed Image background
  • Added background to png images which were unreadable in dark theme
  • Also compressed image to reduce space

Motivation

  • The png images on the website are unreadable in dark theme. Screenshot for reference:
    image

Additional details

  • I have added background to some of the images I found having the issue
  • Fixed image screenshot:
    image

Related issues and pull requests

Relates to #29698

@Sentious Sentious requested a review from a team as a code owner October 21, 2023 05:13
@Sentious Sentious requested review from bsmth and removed request for a team October 21, 2023 05:13
@github-actions github-actions bot added the Content:HTTP HTTP docs label Oct 21, 2023
@Sentious
Copy link
Contributor Author

@wbamberg hey 👋🏽 can you please review the PR and merge if there are no issues. Thanks

@bsmth
Copy link
Member

bsmth commented Oct 23, 2023

There's a PR here which may fix this for all images via CSS: mdn/yari#9863

@wbamberg
Copy link
Collaborator

Yes, like Brian says, it would be better to fix this once for everything. Thanks for your PR, though!

@wbamberg wbamberg closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth Awaiting requested review from bsmth bsmth is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sentious @bsmth @wbamberg