-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client.postMessage
also support passing an options param
#29187
Conversation
Preview URLs (comment last updated: 2023-10-08 15:41:53) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #25342. While this change is sufficient by itself, it would be very helpful if you could look at the other postMessage
methods as well.
Client.postMessage
also support passing an options param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Description
Client.postMessage
also support passing an options paramMotivation
Ditto.
Additional details
https://w3c.github.io/ServiceWorker/#client-postmessage-options
https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage
https://developer.mozilla.org/en-US/docs/Web/API/Worker/postMessage
https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope/postMessage
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorker/postMessage
https://developer.mozilla.org/en-US/docs/Web/API/Client/postMessage
Related issues and pull requests
Related to #25342
Related to #29227