Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.postMessage also support passing an options param #29187

Merged
merged 9 commits into from
Oct 8, 2023

Conversation

@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 18, 2023 16:09
@skyclouds2001 skyclouds2001 requested review from sideshowbarker and removed request for a team September 18, 2023 16:09
@github-actions github-actions bot added the Content:WebAPI Web API docs label Sep 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Preview URLs

(comment last updated: 2023-10-08 15:41:53)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@skyclouds2001

This comment was marked as resolved.

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #25342. While this change is sufficient by itself, it would be very helpful if you could look at the other postMessage methods as well.

@skyclouds2001 skyclouds2001 changed the title Client.postMessage also support passing an options param Client.postMessage also support passing an options param Sep 25, 2023
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Josh-Cena Josh-Cena merged commit 5062632 into mdn:main Oct 8, 2023
@skyclouds2001 skyclouds2001 deleted the patch-4 branch October 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants