-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): Clarify text and example for complex selectors with general sibling combinator (~) #29093
Conversation
Preview URLs (comment last updated: 2023-09-26 01:19:28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that CSS nesting is supported, we may want to not do these edits in favor of adding a nesting example that explains the original issue writers suggestion.
Thanks for the review @estelle and for all your suggestions. (I've updated all occurrences of "compound selectors" to "complex selectors".) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of 'complex selector' wasn't fully accurate or maybe just confusing, so i made some suggestions.
Appreciate your feedback, @estelle; it's been super helpful! I believe this is ready for a final look when you get a chance. |
Thank you! |
Description
The issue and proposed fix was raised in the PR #27124, which was closed due to inaction.
I've opened this new one now to incorporate the suggested changes and add clarifying example and accompanying explanations.