Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Clarify text and example for complex selectors with general sibling combinator (~) #29093

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

dipikabh
Copy link
Contributor

Description

The issue and proposed fix was raised in the PR #27124, which was closed due to inaction.

I've opened this new one now to incorporate the suggested changes and add clarifying example and accompanying explanations.

@dipikabh dipikabh requested a review from a team as a code owner September 13, 2023 16:42
@dipikabh dipikabh requested review from chrisdavidmills and removed request for a team September 13, 2023 16:42
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Preview URLs

(comment last updated: 2023-09-26 01:19:28)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that CSS nesting is supported, we may want to not do these edits in favor of adding a nesting example that explains the original issue writers suggestion.

files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills removed their request for review September 14, 2023 06:05
@dipikabh
Copy link
Contributor Author

Thanks for the review @estelle and for all your suggestions.
Perhaps in another iteration, we can add nesting examples.

(I've updated all occurrences of "compound selectors" to "complex selectors".)

@dipikabh dipikabh requested a review from estelle September 19, 2023 19:12
@dipikabh dipikabh changed the title fix(css): Clarify text and example for compund selectors with general sibling combinator (~) fix(css): Clarify text and example for complex selectors with general sibling combinator (~) Sep 20, 2023
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'complex selector' wasn't fully accurate or maybe just confusing, so i made some suggestions.

files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/general_sibling_combinator/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh requested a review from estelle September 22, 2023 16:08
@dipikabh
Copy link
Contributor Author

Appreciate your feedback, @estelle; it's been super helpful!

I believe this is ready for a final look when you get a chance.

@estelle estelle merged commit 01bb335 into mdn:main Sep 27, 2023
@dipikabh
Copy link
Contributor Author

Thank you!

@dipikabh dipikabh deleted the compound-selectors branch September 27, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants