New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promise support in Chrome clarification #28643

Merged

rebloor merged 6 commits into mdn:main from rebloor:promise-support-in-chrome-clarification

Oct 2, 2023

Contributor

rebloor commented Aug 18, 2023

Description

Addresses the dev-doc-needed for Bug 1711570 support promises on chrome namespace. Also includes miscellaneous edits.


          promise support in Chrome clarification

7bb1b53

rebloor added the Content:WebExt label

rebloor requested review from rpl and Rob--W

August 18, 2023 03:57

rebloor requested a review from a team as a code owner

August 18, 2023 03:57

rebloor self-assigned this

Contributor

github-actions bot commented Aug 18, 2023 •

edited

Loading

Preview URLs

External URLs (14)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Chrome_incompatibilities
Title: Chrome incompatibilities

https://bugzil.la/1208775 (2 times) (Note! This may be a new URL 👀)
https://bugzil.la/1323433 (1 time) (Note! This may be a new URL 👀)
https://bugzil.la/1435864 (1 time) (Note! This may be a new URL 👀)
https://bugzil.la/1525400 (1 time) (Note! This may be a new URL 👀)
https://bugzil.la/1617479 (1 time) (Note! This may be a new URL 👀)
https://crbug.com/328932 (1 time) (Note! This may be a new URL 👀)
https://crbug.com/798169 (2 times) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/ (2 times) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/extensions/reference/declarativeContent/ (1 time) (Note! This may be a new URL 👀)
https://github.com/mozilla/webextension-polyfill (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
Title: Differences between API implementations

https://browserext.github.io/browserext/ (1 time) (Note! This may be a new URL 👀)
https://crbug.com/328932 (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/ (1 time) (Note! This may be a new URL 👀)
https://medium.com/codebuddies/getting-to-know-asynchronous-javascript-callbacks-promises-and-async-await-17e0673281ee (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-10-02 00:46:21)

rebloor commented

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

Rob--W requested changes

View reviewed changes

Member

Rob--W left a comment

Edge does not need to be mentioned separately; it's basically a Chrome clone.

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

rebloor commented

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/differences_between_api_implementations/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

rebloor and others added 3 commits

September 2, 2023 04:12


          Apply suggestions from review

Co-authored-by: Rob Wu <[email protected]>


          Merge branch 'main' into promise-support-in-chrome-clarification

c9b6ac2


          Removed Edge references

31b9bc8

rebloor requested a review from Rob--W

September 1, 2023 16:24

Rob--W approved these changes

View reviewed changes

Member

Rob--W left a comment

Approved for merging, provided that all suggested changes are included. Feel free to copy-edit, but please request another review if the content is changed in substantial ways.

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated

               To work cross-browser, you can specify the path as an absolute URL, starting at the extension's root, like this:
               ```plain
               /path/to/script.js
               ```
-              When querying tabs by URL `tabs.query()`:
+              When querying tabs by URL, with `tabs.query()`:
               - **In Firefox**: Extensions must have the `"tabs"` permission.

Member

Rob--W Sep 30, 2023

Firefox and Chrome's behavior is the same here. Remove this whole section on tabs.query.

This was implemented by Firefox in https://bugzilla.mozilla.org/show_bug.cgi?id=1679688.

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated Show resolved Hide resolved


          Apply suggestions from review

54aaee5

Co-authored-by: Rob Wu <[email protected]>

github-actions bot reviewed

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md Outdated

		@@ -73,21 +73,22 @@ The rest of this page summarizes these and other incompatibilities.
		chrome.cookies.set({ url: "https://developer.mozilla.org/" }, logCookie);
		```

Contributor

github-actions bot Oct 1, 2023

[mdn-linter] _{reported by reviewdog 🐶}

Suggested change


          Removed tabs.query() comments and addressed lint issue

21f957f

rebloor merged commit 311a791 into mdn:main

rebloor deleted the promise-support-in-chrome-clarification branch

October 2, 2023 00:52

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels