New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference for stage 3 set-methods #28414

Merged

estelle merged 5 commits into mdn:main from Josh-Cena:set-methods

Nov 9, 2023

Member

Josh-Cena commented Aug 5, 2023

Description

Adds reference for https://github.com/tc39/proposal-set-methods.

See also mdn/browser-compat-data#20479 for which browsers support it (currently Safari TP and FF nightly).

Motivation

Additional details

Related issues and pull requests

Josh-Cena requested a review from a team as a code owner

August 5, 2023 15:09

Josh-Cena requested review from teoli2003 and removed request for a team

August 5, 2023 15:09

github-actions bot added the Content:JS label

Josh-Cena force-pushed the set-methods branch from 11b419f to 63a90f8 Compare

August 5, 2023 15:13

Contributor

github-actions bot commented Aug 5, 2023 •

edited

Loading

Preview URLs (8 pages)

External URLs (7)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/symmetricDifference
Title: Set.prototype.symmetricDifference()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/intersection
Title: Set.prototype.intersection()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/isSubsetOf
Title: Set.prototype.isSubsetOf()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union
Title: Set.prototype.union()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/isSupersetOf
Title: Set.prototype.isSupersetOf()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/difference
Title: Set.prototype.difference()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/isDisjointFrom
Title: Set.prototype.isDisjointFrom()

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-09-30 03:11:38)

Josh-Cena force-pushed the set-methods branch from 63a90f8 to 4f33dc0 Compare

August 5, 2023 15:18

zloirock reviewed

View reviewed changes

Contributor

zloirock left a comment

Please, add links to core-js polyfills of those methods -)

Member Author

Josh-Cena commented Aug 5, 2023

Sorry, I thought I did 😄

Collaborator

hamishwillee commented Aug 6, 2023 •

edited

Loading

Is someone taking on the compatibility data for this? I can do it if needed, but not going to to so if already in hand.

Member Author

Josh-Cena commented Aug 7, 2023

Already here: mdn/browser-compat-data#20479

Josh-Cena mentioned this pull request

Josh's summer MDN projects #26847

Closed

18 tasks

estelle reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/set/difference/index.md Show resolved Hide resolved

Josh-Cena added 2 commits

September 27, 2023 18:49


          Reference for stage 3 set-methods

30de556


          Add core-js links

b71e70f

Josh-Cena force-pushed the set-methods branch from a9b6a01 to b71e70f Compare

September 27, 2023 22:49

estelle reviewed

View reviewed changes

Member

estelle left a comment

partial review.

files/en-us/web/javascript/reference/global_objects/set/difference/index.md


		In mathematical notation, _difference_ is defined as:

		<math display="block"><semantics><mrow><mi>A</mi><mo>∖</mo><mi>B</mi><mo>=</mo><mo stretchy="false">{</mo><mi>x</mi><mo>∊</mo><mi>A</mi><mo>∣</mo><mi>x</mi><mo>∉</mo><mi>B</mi><mo stretchy="false">}</mo></mrow><annotation encoding="TeX">A\setminus B = \{x\in A\mid x\notin B\}</annotation></semantics></math>

Member

estelle Sep 27, 2023

The <mo>∊</mo> and <mo>∉</mo> are very different sizes. Just want to confirm that that is OK.

Member Author

Josh-Cena Sep 27, 2023

That's mostly a font issue. MDN doesn't seem to be using a decent math font.

files/en-us/web/javascript/reference/global_objects/set/difference/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/difference/index.md


		`difference()` accepts [set-like](/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#set-like_objects) objects as the `other` parameter. It requires {{jsxref("Operators/this", "this")}} to be an actual {{jsxref("Set")}} instance, because it directly retrieves the underlying data stored in `this` without invoking any user code. Then, its behavior depends on the sizes of `this` and `other`:

		- If there are more elements in `this` than `other.size`, then it iterates over `other` by calling its `keys()` method, and constructs a new set with all elements in `this` that are not seen in `other`.

Member

estelle Sep 27, 2023

Suggested change

      
            - If there are more elements in `this` than `other.size`, then it iterates over `other` by calling its `keys()` method, and constructs a new set with all elements in `this` that are not seen in `other`.
          
            - If there are more elements in `this` than `other.size`, then it iterates over `other` by calling its {{jsxref("Set.prototype.keys()", "keys()")}} method, and constructs a new set with all elements in `this` that are not seen in `other`.

or /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys?

Member Author

Josh-Cena Sep 28, 2023

The keys() method here is an arbitrary method that the user provides, which may or may not be Set.prototype.keys(). This is explained in the "set-like objects" section, linked above.

files/en-us/web/javascript/reference/global_objects/set/difference/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/index.md

                 - : Removes all elements from the `Set` object.
               - {{jsxref("Set.prototype.delete()")}}
                 - : Removes the element associated to the `value` and returns a boolean asserting whether an element was successfully removed or not. `Set.prototype.has(value)` will return `false` afterwards.
+              - {{jsxref("Set.prototype.difference()")}}
+                - : Takes a set and returns a new set containing elements in this set but not in the given set.

Member

estelle Sep 27, 2023

Suggested change

      
              - : Takes a set and returns a new set containing elements in this set but not in the given set.
          
              - : Takes a set and returns a new set containing elements in this set that are not in the given set.

Member Author

Josh-Cena Sep 28, 2023

I find both equally fine, but the preposition "but" makes the logical relationship slightly more saliant.

files/en-us/web/javascript/reference/global_objects/set/index.md Outdated Show resolved Hide resolved

files/en-us/web/javascript/reference/global_objects/set/intersection/index.md Outdated Show resolved Hide resolved

Josh-Cena added 3 commits

September 28, 2023 15:42


          Address some reviews

2f10ae9


          Improve alt text


          Little change

56d3696

Josh-Cena requested a review from estelle

September 30, 2023 03:08

estelle approved these changes

View reviewed changes

Member

estelle left a comment

Totally missed this. Sorry. This wasn't in my notifications.

estelle merged commit eccf9de into mdn:main

Josh-Cena deleted the set-methods branch

November 9, 2023 21:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels