Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference for stage 4 regexp-v-flag #26944

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Reference for stage 4 regexp-v-flag #26944

merged 9 commits into from
Jun 22, 2023

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented May 24, 2023

Description

#26847

The most widespread change is to change "non-unicode mode" to "Unicode-unaware mode" to mean "either u or v flags". Other than that, the changes are mainly around ignoreCase, character classes, and Unicode character class escapes.

Also fixes #26617

Motivation

Additional details

https://github.com/tc39/proposal-regexp-v-flag

Related issues and pull requests

@Josh-Cena Josh-Cena requested a review from a team as a code owner May 24, 2023 04:46
@Josh-Cena Josh-Cena requested review from chrisdavidmills and removed request for a team May 24, 2023 04:46
@Josh-Cena Josh-Cena mentioned this pull request May 24, 2023
18 tasks
@github-actions github-actions bot added the Content:JS JavaScript docs label May 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

Preview URLs (27 pages)
Flaws (1)

Note! 26 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicodeSets
Title: RegExp.prototype.unicodeSets
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.RegExp.unicodeSets
External URLs (11)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/ignoreCase
Title: RegExp.prototype.ignoreCase


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicodeSets
Title: RegExp.prototype.unicodeSets


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_class_escape
Title: Character class escape: \d, \D, \w, \W, \s, \S


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_class
Title: Character class: [...], [^...]


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Unicode_character_class_escape
Title: Unicode character class escape: \p{...}, \P{...}


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Word_boundary_assertion
Title: Word boundary assertion: \b, \B

(comment last updated: 2023-06-22 14:29:47)

@Josh-Cena
Copy link
Member Author

I guess @chrisdavidmills will want to review this anyway? You may want to ask V8 folks since V8 is currently the only engine shipping this.

@bsmth bsmth mentioned this pull request Jun 15, 2023
@Josh-Cena Josh-Cena linked an issue Jun 15, 2023 that may be closed by this pull request
Copy link
Contributor

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

@Josh-Cena
Copy link
Member Author

This proposal is now integrated in the main spec, and we are getting quite a few queries recently about the v flag's documentation. Can I get an editorial review from @mdn/yari-content-javascript?

@hamishwillee
Copy link
Collaborator

@chrisdavidmills Are you going to be able to find time to do this? @Josh-Cena I don't consider myself expert enough to give you a great review, but will to do so on Friday if needed.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 20, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 20, 2023
@zcorpan
Copy link
Contributor

zcorpan commented Jun 22, 2023

@mathiasbynens is the subject matter expert here. 🙂

@mathiasbynens
Copy link
Contributor

@mathiasbynens is the subject matter expert here. 🙂

Hah, thanks! I already reviewed + approved the PR, and the suggestions I gave have been addressed, so please don't block on me. This looks really good, and we can always incrementally land improvements if any come up.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me, too. Amazing work, @Josh-Cena! 🎉
I'm going to merge this now.

@Elchi3 Elchi3 merged commit fc67640 into mdn:main Jun 22, 2023
@Josh-Cena Josh-Cena deleted the v-mode branch June 22, 2023 15:46
@Josh-Cena
Copy link
Member Author

Thanks @Elchi3!

behnammodi pushed a commit to behnammodi/content that referenced this pull request Jun 26, 2023
* Reference for stage 4 regexp-v-flag

* Prettier

* Add a note

* Update index.md

* Apply suggestions from code review

Co-authored-by: Mathias Bynens <[email protected]>

* Avoid duplication

---------

Co-authored-by: Mathias Bynens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegExp v flag not documented Emphasize the difference between Javascript and ICU for Unicode properties
5 participants