-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference for stage 4 regexp-v-flag #26944
Conversation
I guess @chrisdavidmills will want to review this anyway? You may want to ask V8 folks since V8 is currently the only engine shipping this. |
...s/en-us/web/javascript/reference/regular_expressions/unicode_character_class_escape/index.md
Outdated
Show resolved
Hide resolved
...s/en-us/web/javascript/reference/regular_expressions/unicode_character_class_escape/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some suggestions
Co-authored-by: Mathias Bynens <[email protected]>
This proposal is now integrated in the main spec, and we are getting quite a few queries recently about the v flag's documentation. Can I get an editorial review from @mdn/yari-content-javascript? |
@chrisdavidmills Are you going to be able to find time to do this? @Josh-Cena I don't consider myself expert enough to give you a great review, but will to do so on Friday if needed. |
This pull request has merge conflicts that must be resolved before it can be merged. |
@mathiasbynens is the subject matter expert here. 🙂 |
Hah, thanks! I already reviewed + approved the PR, and the suggestions I gave have been addressed, so please don't block on me. This looks really good, and we can always incrementally land improvements if any come up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me, too. Amazing work, @Josh-Cena! 🎉
I'm going to merge this now.
Thanks @Elchi3! |
* Reference for stage 4 regexp-v-flag * Prettier * Add a note * Update index.md * Apply suggestions from code review Co-authored-by: Mathias Bynens <[email protected]> * Avoid duplication --------- Co-authored-by: Mathias Bynens <[email protected]>
Description
#26847
The most widespread change is to change "non-unicode mode" to "Unicode-unaware mode" to mean "either
u
orv
flags". Other than that, the changes are mainly aroundignoreCase
, character classes, and Unicode character class escapes.Also fixes #26617
Motivation
Additional details
https://github.com/tc39/proposal-regexp-v-flag
Related issues and pull requests