-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for the VirtualKeyboard API #22949
Conversation
In talking to @tomayac, I learned that @chrisdavidmills was maybe planning on working on this. Chris, would you mind giving this a review then? |
@captainbrosset Yup, more than happy to. I'll get my review done probably before the end of today. |
I see that images need to be compressed. I tried running the following suggested commands but the files didn't get changed on disk:
|
@caugner , any thoughts on why the file compression commands don't appear to be working for @captainbrosset ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @captainbrosset ! I've left a bunch of suggestions and comments here, but they are mostly language nitpicks and a few tips on macro usage, etc. These docs are interesting and informative, and I enjoyed reading them. Nice job!
files/en-us/web/api/virtualkeyboard/geometrychange_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/virtualkeyboard/geometrychange_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/virtualkeyboard/geometrychange_event/index.md
Outdated
Show resolved
Hide resolved
Thank you @chrisdavidmills for the thorough review. I'm pushing a new commit which addresses your comments in a second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@captainbrosset Much improved, thank you ! I've left a few more comments to point out some more bits I noticed, but not nearly as many this time.
Since I don't have permission to approve this PR, I'm handing it over to @Elchi3 to do the honours ;-)
The latest comments from @chrisdavidmills should be addressed now. |
Thank you @Elchi3! I just pushed a commit with your screenshots. Let's see if that worked ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have worked 🎉
I scrolled through the pages briefly and looks good to me. Chris already provided a more in-depth review. Thanks for writing this up, Patrick! 👍
Nice work @captainbrosset ! |
Description
This PR adds the necessary documentation for the VirtualKeyboard API.
Motivation
The VirtualKeyboard API shipped in chromium-based browsers over a year ago (here is the CL where it got enabled).
It then was documented on BCD (here) which means that it's available on caniuse (here). And it was documented by Thomas Steiner on developer.chrome.com (here).
Although this is still only in Chromium-based browsers (mozilla position, webkit position), it's very useful on mobile devices and can be used as a progressive enhancement on supporting browsers. I think this API should absolutely be documented on MDN.