-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding docs for WebTransport #22310
adding docs for WebTransport #22310
Conversation
I’ll take a look at this now |
Co-authored-by: Michael[tm] Smith <[email protected]>
Co-authored-by: Michael[tm] Smith <[email protected]>
Thanks for the suggestions @sideshowbarker ; committed! I also made some code updates in response to some comments the spec author gave me over email. I'll see if I can get a more thorough SME review at some point; do you think this is ready to be published? |
👍
It’s up to you, but I would vote for going ahead and merging this now. I think this is of sufficient quality that we should get it out to developers to read and use now rather than waiting. You could get more review post-commit — and you could (if you wanted to) ask SMEs to review the actual published articles on the production site, and submit pull requests with suggested changes. Personally I find that can be a productive way to get detailed review, and get fixes and refinements made efficiently. If you did that, having an SME start with review of the https://developer.mozilla.org/en-US/docs/Web/API/WebTransport_API article would seem like a good way to give it a try. But again it’s up to you — I’m happy to go ahead and push the merge button on this now, but also happy to wait if you want to get more review of it before we land it |
@sideshowbarker go ahead and merge it. I agree with your reasoning here, and I just got approval from the Chrome team to do so, too. Thanks! |
Description
This PR provides docs for the WebTransport API data. You can see more details about my work in my research document
Review status: awaiting tech review from a Chromium SME.
A couple of notes:
WebTransportError
pages. I thought my example would return aWebTransportError
, buterror.source
anderror.streamErrorCode
return undefined.WebTransport.incomingUnidirectionalStreams
ReadableStream
are of typeWebTransportReceiveStream
, or whether these are justReadableStream
s for now. It doesn't matter hugely for the examples given, as the effect is the same either way, but it is hard to test, and it'd be good to get this right.Motivation
High profile new API for developers to learn about.
Additional details
Related issues and pull requests
Fixes #22281