Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding docs for WebTransport #22310

Merged
merged 6 commits into from
Dec 19, 2022

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Nov 15, 2022

Description

This PR provides docs for the WebTransport API data. You can see more details about my work in my research document

Review status: awaiting tech review from a Chromium SME.

A couple of notes:

  1. I'm not really sure about my example on the WebTransportError pages. I thought my example would return a WebTransportError, but error.source and error.streamErrorCode return undefined.
  2. I'm still not quite sure if the chunks transmitted by the WebTransport.incomingUnidirectionalStreams ReadableStream are of type WebTransportReceiveStream, or whether these are just ReadableStreams for now. It doesn't matter hugely for the examples given, as the effect is the same either way, but it is hard to test, and it'd be good to get this right.

Motivation

High profile new API for developers to learn about.

Additional details

Related issues and pull requests

Fixes #22281

@chrisdavidmills chrisdavidmills requested review from a team as code owners November 15, 2022 15:26
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and bsmth and removed request for a team November 15, 2022 15:26
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Preview URLs (26 pages)
Flaws (4)

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WebTransport
Title: WebTransport
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/WebTransportReceiveStream does not exist

URL: /en-US/docs/Web/API/WebTransport/incomingUnidirectionalStreams
Title: WebTransport.incomingUnidirectionalStreams
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/WebTransportReceiveStream does not exist
    • /en-US/docs/Web/API/WebTransportReceiveStream does not exist
    • /en-US/docs/Web/API/WebTransportReceiveStream does not exist
External URLs (55)

URL: /en-US/docs/Web/API/WebTransportError
Title: WebTransportError


URL: /en-US/docs/Web/API/WebTransportError/WebTransportError
Title: WebTransportError()


URL: /en-US/docs/Web/API/WebTransportError/streamErrorCode
Title: WebTransportError.streamErrorCode


URL: /en-US/docs/Web/API/WebTransportError/source
Title: WebTransportError.source


URL: /en-US/docs/Web/API/WebTransport_API
Title: WebTransport API


URL: /en-US/docs/Web/API/WebTransportBidirectionalStream
Title: WebTransportBidirectionalStream


URL: /en-US/docs/Web/API/WebTransportBidirectionalStream/writable
Title: WebTransportBidirectionalStream.writable


URL: /en-US/docs/Web/API/WebTransportBidirectionalStream/readable
Title: WebTransportBidirectionalStream.readable


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream
Title: WebTransportDatagramDuplexStream


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/outgoingHighWaterMark
Title: WebTransportDatagramDuplexStream.outgoingHighWaterMark


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/incomingHighWaterMark
Title: WebTransportDatagramDuplexStream.incomingHighWaterMark


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/maxDatagramSize
Title: WebTransportDatagramDuplexStream.maxDatagramSize


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/outgoingMaxAge
Title: WebTransportDatagramDuplexStream.outgoingMaxAge


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/writable
Title: WebTransportDatagramDuplexStream.writable


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/incomingMaxAge
Title: WebTransportDatagramDuplexStream.incomingMaxAge


URL: /en-US/docs/Web/API/WebTransportDatagramDuplexStream/readable
Title: WebTransportDatagramDuplexStream.readable


URL: /en-US/docs/Web/API/WebTransport
Title: WebTransport


URL: /en-US/docs/Web/API/WebTransport/incomingUnidirectionalStreams
Title: WebTransport.incomingUnidirectionalStreams


URL: /en-US/docs/Web/API/WebTransport/createBidirectionalStream
Title: WebTransport.createBidirectionalStream()


URL: /en-US/docs/Web/API/WebTransport/createUnidirectionalStream
Title: WebTransport.createUnidirectionalStream()


URL: /en-US/docs/Web/API/WebTransport/ready
Title: WebTransport.ready


URL: /en-US/docs/Web/API/WebTransport/close
Title: WebTransport.close()


URL: /en-US/docs/Web/API/WebTransport/closed
Title: WebTransport.closed


URL: /en-US/docs/Web/API/WebTransport/datagrams
Title: WebTransport.datagrams


URL: /en-US/docs/Web/API/WebTransport/WebTransport
Title: WebTransport()


URL: /en-US/docs/Web/API/WebTransport/incomingBidirectionalStreams
Title: WebTransport.incomingBidirectionalStreams

(comment last updated: 2022-12-19 08:50:45)

@chrisdavidmills chrisdavidmills marked this pull request as ready for review December 5, 2022 07:15
@sideshowbarker sideshowbarker self-assigned this Dec 14, 2022
@sideshowbarker
Copy link
Member

I’ll take a look at this now

files/en-us/web/api/webtransport_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/webtransport_api/index.md Outdated Show resolved Hide resolved
@chrisdavidmills
Copy link
Contributor Author

Thanks for the suggestions @sideshowbarker ; committed!

I also made some code updates in response to some comments the spec author gave me over email. I'll see if I can get a more thorough SME review at some point; do you think this is ready to be published?

@sideshowbarker
Copy link
Member

Thanks for the suggestions @sideshowbarker ; committed!

👍

I also made some code updates in response to some comments the spec author gave me over email. I'll see if I can get a more thorough SME review at some point; do you think this is ready to be published?

It’s up to you, but I would vote for going ahead and merging this now.

I think this is of sufficient quality that we should get it out to developers to read and use now rather than waiting.

You could get more review post-commit — and you could (if you wanted to) ask SMEs to review the actual published articles on the production site, and submit pull requests with suggested changes. Personally I find that can be a productive way to get detailed review, and get fixes and refinements made efficiently.

If you did that, having an SME start with review of the https://developer.mozilla.org/en-US/docs/Web/API/WebTransport_API article would seem like a good way to give it a try.

But again it’s up to you — I’m happy to go ahead and push the merge button on this now, but also happy to wait if you want to get more review of it before we land it

@chrisdavidmills
Copy link
Contributor Author

But again it’s up to you — I’m happy to go ahead and push the merge button on this now, but also happy to wait if you want to get more review of it before we land it

@sideshowbarker go ahead and merge it. I agree with your reasoning here, and I just got approval from the Chrome team to do so, too. Thanks!

@sideshowbarker sideshowbarker merged commit 9a2b9e5 into mdn:main Dec 19, 2022
@chrisdavidmills chrisdavidmills deleted the add-WebTransport-docs branch December 19, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent to document: WebTransport API
2 participants