Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two+ trailing spaces in text #19866

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Aug 23, 2022

The test in PR #19863 shows that the markdownlinter or the current configuration doesn't detect more than one trailing spaces.

Fixing the spaces in text first.

cc: @teoli2003, @nschonni

@OnkarRuikar OnkarRuikar requested review from a team as code owners August 23, 2022 08:02
@OnkarRuikar OnkarRuikar requested review from jpmedley, estelle and Rumyra and removed request for a team August 23, 2022 08:02
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Aug 23, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Tutorials
Title: Tutorials
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Multiprocess_Firefox

URL: /en-US/docs/Web/API/CSSRule/type
Title: CSSRule.type
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/CSSDocumentRule does not exist
    • /en-US/docs/Web/API/CSSFontFeatureValuesRule does not exist
    • /en-US/docs/Web/API/CSSViewportRule does not exist
    • /en-US/docs/Web/API/CSSRegionStyleRule does not exist

URL: /en-US/docs/Web/API/XSLTProcessor
Title: XSLTProcessor
on GitHub
Flaw count: 19

  • macros:
    • /en-US/docs/Web/API/XSLTProcessor/XSLTProcessor does not exist
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToFragment does not exist
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToDocument does not exist
    • and 6 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 3 more flaws omitted

URL: /en-US/docs/MDN/Writing_guidelines/Writing_style_guide
Title: Writing style guide
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Guide/Details_of_the_Object_Model

External URLs

URL: /en-US/docs/Web/Tutorials
Title: Tutorials
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/CSS_Scroll_Snap/Basic_concepts
Title: Basic concepts of CSS Scroll Snap
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/IDBKeyRange/lowerOpen
Title: IDBKeyRange.lowerOpen
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CSSRule/type
Title: CSSRule.type
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Headers/forEach
Title: Headers.forEach()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGStyleElement
Title: SVGStyleElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XSLTProcessor
Title: XSLTProcessor
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Writing_guidelines/Writing_style_guide
Title: Writing style guide
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Writing_guidelines/What_we_write
Title: What we write
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit efc7d10 into mdn:main Aug 23, 2022
@OnkarRuikar OnkarRuikar deleted the fix_two_tspaces branch August 23, 2022 08:31
@nschonni
Copy link
Contributor

LGTM, but note that 2 trailing spaces has a special meaning in Markdown/CommonMark to create a BR tag https://spec.commonmark.org/0.30/#hard-line-break
That's why Markdownlint doesn't strip them if they're there, but does if it is an odd number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants