Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out ellipsis in code blocks #18568

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Comment out ellipsis in code blocks #18568

merged 1 commit into from
Jul 21, 2022

Conversation

OnkarRuikar
Copy link
Contributor

Ellipsis in markdown code blocks are syntax errors.

In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses. Refer the #18171 (comment) for more context.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 21, 2022 03:03
@OnkarRuikar OnkarRuikar requested review from Josh-Cena and removed request for a team July 21, 2022 03:03
@github-actions github-actions bot added the Content:JS JavaScript docs label Jul 21, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 23 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/ceil
Title: Math.ceil()
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
Title: Boolean
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty
Title: Object.defineProperty()
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/proto
Title: Object.prototype.__proto__
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
    • and 3 more flaws omitted

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/preventExtensions
Title: Object.preventExtensions()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/Strict_mode redirects to /en-US/docs/Web/JavaScript/Reference/Strict_mode

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
Title: Object.hasOwn()
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create
Title: Object.create()
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now
Title: Date.now()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getTime
Title: Date.prototype.getTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/floor
Title: Math.floor()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/ceil
Title: Math.ceil()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/max
Title: Math.max()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/hypot
Title: Math.hypot()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/min
Title: Math.min()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
Title: Boolean
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator
Title: Generator
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry
Title: FinalizationRegistry
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry/FinalizationRegistry
Title: FinalizationRegistry() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty
Title: Object.defineProperty()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/proto
Title: Object.prototype.__proto__
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/isExtensible
Title: Object.isExtensible()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/preventExtensions
Title: Object.preventExtensions()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
Title: Object.hasOwn()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/constructor
Title: Object.prototype.constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/isFrozen
Title: Object.isFrozen()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create
Title: Object.create()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply
Title: Function.prototype.apply()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name
Title: Function.prototype.name
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice
Title: Array.prototype.splice()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
Title: Array.prototype.sort()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/unshift
Title: Array.prototype.unshift()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/forEach
Title: Map.prototype.forEach()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error
Title: Error
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause
Title: Error.prototype.cause
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error
Title: Error() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf
Title: Intl.supportedValuesOf()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/eval
Title: eval()
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit ea3c7e8 into mdn:main Jul 21, 2022
@OnkarRuikar OnkarRuikar deleted the code-ellipsis3 branch July 21, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003