Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out ellipsis in code blocks #18535

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Comment out ellipsis in code blocks #18535

merged 3 commits into from
Jul 20, 2022

Conversation

OnkarRuikar
Copy link
Contributor

Ellipsis in markdown code blocks are syntax errors.

In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses. Refer the #18171 (comment) for more context.

@OnkarRuikar OnkarRuikar requested review from a team as code owners July 20, 2022 02:29
@OnkarRuikar OnkarRuikar requested review from jpmedley and estelle and removed request for a team July 20, 2022 02:29
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs labels Jul 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 26 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/:is
Title: :is() (:matches(), :any())
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

URL: /en-US/docs/Web/CSS/Media_Queries/Testing_media_queries
Title: Testing media queries programmatically
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaQueryListListener redirects to /en-US/docs/Web/API/MediaQueryList

URL: /en-US/docs/Web/CSS/cursor
Title: cursor
on GitHub
Flaw count: 1

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/CSSSyntax.ejs:1

1| <%
2| /*
3| * Displays the formal syntax for a CSS property, using the values found in
4| * the https://github.com/w3c/webref package.

Unexpected input
[ [ | ] [ ]? ]#? [ auto | default | none | context-menu | help | pointer | progress | wait | cell | crosshair | text | vertical-text | alias | copy | move | no-drop | not-allowed | grab | grabbing | e-resize | n-resize | ne-resize | nw-resize | s-resize | se-resize | sw-resize | w-resize | ew-resize | ns-resize | nesw-resize | nwse-resize | col-resize | row-resize | all-scroll | zoom-in | zoom-out ]
---------------------------------------^`

URL: /en-US/docs/Web/API/XRProjectionLayer/fixedFoveation
Title: XRProjectionLayer.fixedFoveation
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.XRProjectionLayer.fixedFoveation

URL: /en-US/docs/Web/API/XRWebGLBinding/createCylinderLayer
Title: XRWebGLBinding.createCylinderLayer()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/GLenum redirects to /en-US/docs/Web/API/WebGL_API/Types
    • /en-US/docs/Web/API/GLenum redirects to /en-US/docs/Web/API/WebGL_API/Types
  • bad_bcd_queries:
    • No BCD data for query: api.XRWebGLBinding.createCylinderLayer

External URLs

URL: /en-US/docs/Web/CSS/border-radius
Title: border-radius
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/text-transform
Title: text-transform
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/:where
Title: :where()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/:is
Title: :is() (:matches(), :any())
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/margin-trim
Title: margin-trim
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-decoration-break
Title: box-decoration-break
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/::placeholder
Title: ::placeholder
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
Title: Using multiple backgrounds
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/:not
Title: :not()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Alternative_style_sheets
Title: Alternative style sheets
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/General_sibling_combinator
Title: General sibling combinator
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/content-visibility
Title: content-visibility
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Media_Queries/Testing_media_queries
Title: Testing media queries programmatically
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
Title: Using media queries
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/resolution
Title: <resolution>
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/cursor
Title: cursor
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@media/-webkit-device-pixel-ratio
Title: -webkit-device-pixel-ratio
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Selectors/Using_the_:target_pseudo-class_in_selectors
Title: Using the :target pseudo-class in selectors
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/order
Title: order
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/line-height
Title: line-height
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/ratio
Title: <ratio>
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRProjectionLayer/fixedFoveation
Title: XRProjectionLayer.fixedFoveation
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRWebGLBinding/getDepthInformation
Title: XRWebGLBinding.getDepthInformation()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRWebGLBinding/createCylinderLayer
Title: XRWebGLBinding.createCylinderLayer()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRReferenceSpace
Title: XRReferenceSpace
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRSystem/devicechange_event
Title: XRSystem: devicechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XSLTProcessor/Generating_HTML
Title: Generating HTML
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRLightEstimate/primaryLightDirection
Title: XRLightEstimate.primaryLightDirection
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRLightEstimate/sphericalHarmonicsCoefficients
Title: XRLightEstimate.sphericalHarmonicsCoefficients
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRLightEstimate/primaryLightIntensity
Title: XRLightEstimate.primaryLightIntensity
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRRigidTransform/inverse
Title: XRRigidTransform.inverse
on GitHub

No new external URLs

(this comment was updated 2022-07-20 06:10:00.916097)

@teoli2003 teoli2003 requested review from teoli2003 and removed request for jpmedley and estelle July 20, 2022 05:53
teoli2003
teoli2003 suggested changes Jul 20, 2022
View reviewed changes
files/en-us/web/css/@media/-webkit-device-pixel-ratio/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@media/-webkit-device-pixel-ratio/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_doublecolon_placeholder/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_doublecolon_placeholder/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/media_queries/using_media_queries/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/media_queries/using_media_queries/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/media_queries/using_media_queries/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/media_queries/using_media_queries/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/ratio/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/resolution/index.md Outdated Show resolved Hide resolved
@OnkarRuikar
Copy link
Contributor Author

Thanks!

teoli2003
teoli2003 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 97783d1 into mdn:main Jul 20, 2022
@OnkarRuikar OnkarRuikar deleted the code-ellipsis5 branch July 20, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003