Correct usage of ellipsis #18170
Merged
Correct usage of ellipsis #18170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
requested review from
wbamberg,
teoli2003,
schalkneethling and
estelle
and removed request for
a team
github-actions
bot
added
Content:Glossary
This comment was marked as resolved.
This comment was marked as resolved.
|
The ellipsis is used for an unfinished enumeration. In most cases here, it is used to mark a pause, we should use a comma. I'm going to edit this directly here. |
|
(Or em-dashes—because who doesn't like em-dashes?) |
Josh-Cena
reviewed
Jul 10, 2022
| @@ -49,7 +49,7 @@ Conditional statements allow us to represent such decision making in JavaScript, | |||
|
|
|||
| Let's look at by far the most common type of conditional statement you'll use in JavaScript — the humble [`if...else` statement](/en-US/docs/Web/JavaScript/Reference/Statements/if...else). | |||
|
|
|||
| ### Basic if ... else syntax | |||
| ### Basic if … else syntax | |||
There was a problem hiding this comment.
Should this be if...else? This seems just the same as for...of.
It's also used for unfinished thoughts or obvious part left out. [ref] |
teoli2003
suggested changes
Jul 10, 2022
| @@ -158,7 +158,7 @@ Back to the topic of the main loop. You will often want to know when your main f | |||
|
|
|||
| Several other optimizations are possible and it really depends on what your game attempts to accomplish. Your game genre will obviously make a difference but it could even be more subtle than that. You could draw every pixel individually on a canvas or you could layer DOM elements (including multiple WebGL canvases with transparent backgrounds if you want) into a complex hierarchy. Each of these paths will lead to different opportunities and constraints. | |||
|
|
|||
| ## It is decision... time | |||
| ## It is decision… time | |||
There was a problem hiding this comment.
Suggested change
| ## It is decision… time | |
| ## It is decision time |
files/en-us/learn/common_questions/checking_that_your_web_site_is_working_properly/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/api_reference_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/glossary_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/html_element_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/html_element_page_template/index.md
Outdated
Show resolved
Hide resolved
Yes, I've done a mix, depending on the place. Authors on MDN overuse ellipsis… |
|
Hot take: ellipsis is just a subpar alternative of "etc." + em-dash + comma 😄 |
Co-authored-by: Jean-Yves Perrier <[email protected]>
teoli2003
approved these changes
Jul 10, 2022
This was referenced Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing ellipsis before #17988 gets in.
We don't have to worry about
for...ofif we use...\s.