Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curly -> straight apostrophes #16770

Merged
merged 2 commits into from
May 30, 2022
Merged

Conversation

OnkarRuikar
Copy link
Contributor

Adding to #16324

@OnkarRuikar OnkarRuikar requested review from a team as code owners May 30, 2022 02:21
@OnkarRuikar OnkarRuikar requested review from a team, teoli2003, dipikabh and Guyzeroth and removed request for a team May 30, 2022 02:21
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs labels May 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Statements/with
Title: with
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist

URL: /en-US/docs/Web/HTTP/Caching
Title: HTTP caching
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API

External URLs

URL: /en-US/docs/Web
Title: Web technology for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Template_literals
Title: Template literals (Template strings)
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Statements/with
Title: with
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Guide/Grammar_and_types
Title: Grammar and types
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Caching
Title: HTTP caching
on GitHub


URL: /en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types
Title: MIME types (IANA media types)
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/X-Forwarded-For
Title: X-Forwarded-For
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/number
Title: <input type="number">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/source
Title: <source>: The Media or Image Source element
on GitHub

No new external URLs

(this comment was updated 2022-05-30 05:43:14.815101)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive how they creep back in… On fix and we can merge this.

files/en-us/_redirects.txt Outdated Show resolved Hide resolved
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented May 30, 2022

GitHub is bugging out on the redirects file. Had to push it from local.

Impressive how they creep back in…

They are also known as typographer's apostrophes. Either people have configured their keyboards or some locale has them by default.

We need to add this rule to the linter WDYT?

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 7449143 into mdn:main May 30, 2022
@teoli2003
Copy link
Contributor

GitHub is bugging out on the redirects file. Had to push it from local.

Impressive how they creep back in…

They are also known as typographer's apostrophes. Either people have configured their keyboards or some locale has them by default.
I know them, but I've cleaned them 2 weeks ago :-)

We need to add this rule to the linter WDYT?

Yeah, that would be good (also the curly quotes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants