Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a need of polyfills now for es5 Array methods #10072

Closed
5 tasks
AnilSeervi opened this issue Oct 25, 2021 · 8 comments
Closed
5 tasks

Is there a need of polyfills now for es5 Array methods #10072

AnilSeervi opened this issue Oct 25, 2021 · 8 comments
Labels
Content:JS JavaScript docs

Comments

@AnilSeervi
Copy link
Contributor

AnilSeervi commented Oct 25, 2021

What information was incorrect, unhelpful, or incomplete?

I think the polyfill isn't necessary now as es5 supported by most of the browsers now.
If it is to be removed then I'd like to work on it.

Some other pages that have the polyfills :

  • Array.some()
  • Array.map()
  • Array.lastIndexOf()
  • Array.every()
  • Array.reduceRight()
@wbamberg
Copy link
Collaborator

What information was incorrect, unhelpful, or incomplete?

I think the polyfill isn't necessary now as es5 supported by most of the browsers now. If it is to be removed then I'd like to work on it.

Some other pages that have the polyfills :

  • Array.some()

  • Array.map()

  • Array.lastIndexOf()

  • Array.every()

  • Array.reduceRight()

It's a good question. As you might know we have a proposed project to sort out polyfills on MDN, that didn't get prioritised in this quarter but which I do expect we will get to in 2022 (openwebdocs/project#27). As part of that @teoli2003 started a discussion about when we should have any polyfills at all: https://github.com/mdn/content/discussions/7841 and by his proposed criteria we should remove them at least for the 5 pages you've listed here, which are all supported from IE9.

So I'd say: yes, we can remove these. I'll drop a link to this issue in the discussion.

@zloirock

This comment has been minimized.

@wbamberg

This comment has been minimized.

@zloirock

This comment has been minimized.

@zloirock
Copy link
Contributor

zloirock commented Oct 29, 2021

However, I agree that naive polyfills posted directly on MDN that do not cover modern cases and sometimes even are harmful should be removed.

@ddbeck

This comment has been minimized.

@zloirock

This comment has been minimized.

@ddbeck

This comment has been minimized.

@ddbeck ddbeck added Content:JS JavaScript docs question labels Nov 4, 2021
@Rumyra Rumyra added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 25, 2021
AnilSeervi added a commit to AnilSeervi/content that referenced this issue Jan 16, 2022
@sideshowbarker sideshowbarker removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 16, 2022
@mdn mdn locked and limited conversation to collaborators Jan 16, 2022
@sideshowbarker sideshowbarker converted this issue into a discussion Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs
Projects
None yet
Development

No branches or pull requests

6 participants