Remove old flags for CSS Grid #9683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all enabled more than two years ago and can be removed: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-flag-data The only irregular edit here is for the repeat() features of grid-template-columns and grid-template-rows. There, the Firefox for Android data was out of sync with Firefox, and was made to match. Initial changes produced using @vinyldarkscratch's excellent script: https://github.com/vinyldarkscratch/browser-compat-data/tree/scripts/remove-redundant-flags
github-actions
bot
added
the
data:css
foolip
commented
Mar 31, 2021
| } | ||
| ], | ||
| "firefox_android": [ | ||
| { | ||
| "version_added": "52" | ||
| "version_added": "76" |
There was a problem hiding this comment.
Here's the first irregular change to look extra carefully at.
There was a problem hiding this comment.
Looking at the data, this seems like a reasonable change to me. The commit history indicates that changes were made to Firefox desktop that should have been made to FxA as well, but weren't. I can't think of a reason that the data should vary between the two.
foolip
commented
Mar 31, 2021
| } | ||
| ], | ||
| "firefox_android": [ | ||
| { | ||
| "version_added": "52" | ||
| "version_added": "76" |
There was a problem hiding this comment.
Here's the other irregular change to look extra carefully at.
There was a problem hiding this comment.
Looks like the same case here, so we're all good!
Chrome 57 and Firefox 52 were confirmed as the versions when the properties were first supported with these tests: http://mdn-bcd-collector.appspot.com/tests/css/properties/grid-template-columns http://mdn-bcd-collector.appspot.com/tests/css/properties/grid-template-rows
queengooborg
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all enabled more than two years ago and can be removed:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-flag-data
The only irregular edit here is for the repeat() features of
grid-template-columns and grid-template-rows. There, the Firefox for
Android data was out of sync with Firefox, and was made to match.
Initial changes produced using @vinyldarkscratch's excellent script:
https://github.com/vinyldarkscratch/browser-compat-data/tree/scripts/remove-redundant-flags