Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incumbent realm tracking support to Promises table #7568

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

codehag
Copy link
Contributor

@codehag codehag commented Dec 4, 2020

This address mdn/sprints#3495

Incumbent realm tracking has been part of the html spec for some time: https://html.spec.whatwg.org/#incumbent:incumbent-settings-object-6:~:text=The%20following%20series%20of%20examples%20is,the%20definition%20of%20the%20incumbent%20concept%3A but it was not specified in JS that this behaviour was intended until recently: https://tc39.es/ecma262/#sec-hostmakejobcallback

At present, FF is the only browser supporting it, but chrome has signalled that they are willing to implement it: whatwg/html#5722 (review)

One of the requirements for this to be merged, is adding documentation to MDN.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Dec 4, 2020
@codehag codehag force-pushed the incumbent_realm_promises branch 2 times, most recently from 8f192ca to af52c77 Compare December 4, 2020 11:52
@codehag codehag force-pushed the incumbent_realm_promises branch from af52c77 to 967a517 Compare December 4, 2020 12:13
Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we consider renaming this feature incumbent_realm_tracking in BCD, and “Incumbent-realm tracking” in MDN and elsewhere.

javascript/builtins/Promise.json Outdated Show resolved Hide resolved
javascript/builtins/Promise.json Outdated Show resolved Hide resolved
javascript/builtins/Promise.json Outdated Show resolved Hide resolved
@sideshowbarker sideshowbarker merged commit 771d341 into mdn:master Dec 9, 2020
@sideshowbarker
Copy link
Contributor

Thanks, and welcome to the browser-compat-data project 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants