-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update audioTracks/videoTracks/textTracks versions for Safari #6644
Update audioTracks/videoTracks/textTracks versions for Safari #6644
Conversation
https://trac.webkit.org/changeset/178172/webkit does not seems related to shipping audioTracks/videoTracks/textTracks, it only moves them around in the IDL file and they're still behind |
Understanding when this really shipped is made more complicated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to confirm the suggested versions, so more evidence would be great.
api/SourceBuffer.json
Outdated
@@ -75,7 +75,7 @@ | |||
"version_added": "8" | |||
}, | |||
"safari_ios": { | |||
"version_added": false | |||
"version_added": "8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested http://software.hixie.ch/utilities/js/live-dom-viewer/saved/8420 on iPhones in BrowserStack to try to confirm when MSE was added, but it's not there even on Safari 13. https://caniuse.com/mediasource suggests that it's only for iPad. If that's correct, we should have notes in the BCD data as well.
api/SourceBuffer.json
Outdated
@@ -471,10 +471,10 @@ | |||
"version_added": "14" | |||
}, | |||
"safari": { | |||
"version_added": "8" | |||
"version_added": "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8419 on Safari (macOS) in BrowserStack and see support at least back to 10.1. Before that point I'm not sure because the interface object was not exposed at one point. But at any case the methodology here seems unreliable, so another look would be good.
Paging in @eric-carlson and @jernoble, who I think will be able to give us some guidance here. Eric, Jer, we’re trying to figure out two things:
|
This first landed in Safari 8 on MacOS X Yosemite, and in Mobile Safari on iOS 8.
This also landed in Safari 8 on MacOS X Yosemite, and later in Mobile Safari on iPad in iOS 13. |
@jernoble Thanks much One thing I realize now I should have been more clear about: given that both So can you please either confirm the following, or let me know any further corrections needed —
Specifically, the particular details I’m not completely sure about are:
|
Yes, those properties were exposed from the start. https://bugs.webkit.org/show_bug.cgi?id=123374
No, Mobile Safari on iPhone does not expose any MSE APIs. |
9c194ee
to
c1aa1ed
Compare
This change corrects the Safari version data for the audioTracks, videoTracks, and textTracks members of the SourceBuffer interface to reflect, per https://bugs.webkit.org/show_bug.cgi?id=123374, the actual version of Safari which first shipped support for them. The change also updates the Safari version data for the audioTracks, videoTracks, and textTracks members of the HTMLMediaElement interface. Relates to mdn#6102
c1aa1ed
to
6ddd615
Compare
@foolip I amended the commit to reflect the details from Jer. To document what Jer indicated about |
We've discussed separating iPadOS into its own column in #6326 a bit. For now, I think you've got the right idea to add a note! |
Yep putting this in a note is the way to go right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jernoble for confirming the releases for these bits, and thanks @sideshowbarker! I'll go ahead and land this now.
@vinyldarkscratch there ought to be a whole bunch of MSE APIs that can be updated in a similar way to this PR, in case you want to collect results from iPad. |
This change corrects the Safari version data for the
audioTracks
,videoTracks
, andtextTracks
members of theSourceBuffer
interface to reflect, per https://trac.webkit.org/changeset/178172/webkit, the actual version of Safari which first shipped support for them.Relates to #6102