Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Storage Access API compat data #2990

Merged
merged 11 commits into from
Nov 1, 2018
Merged

Adding Storage Access API compat data #2990

merged 11 commits into from
Nov 1, 2018

Conversation

chrisdavidmills
Copy link
Contributor

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 15, 2018
…ersion numbers to Fx 65, updating Safari support
@Elchi3
Copy link
Member

Elchi3 commented Oct 16, 2018

The Firefox version data updates would be better in a separate PR. Also, we probably want to add some more future versions, so that we don't have to update this too frequently. I think last time we added like the next 5 Firefox releases.

@chrisdavidmills
Copy link
Contributor Author

I appreciate that; I only added it here because I was worried that the data would error if it didn't have the versions in place.

@Elchi3
Copy link
Member

Elchi3 commented Oct 16, 2018

Done in #2995

@chrisdavidmills
Copy link
Contributor Author

OK, in that case I've removed the browser changes I added.

@chrisdavidmills
Copy link
Contributor Author

This has failed because of the invalid version number thing. I take it this can be merged given that you added that stuff separately?

@Elchi3
Copy link
Member

Elchi3 commented Oct 17, 2018

Three things before this is good to go:

  1. If you rebase against master, the failures should be gone, because, yes, I merged the Firefox version updates to master.

  2. It would be nice to have an agreement on updating sandbox sub-items to hopefully make them easier to read #2994 first and have the addition here be aligned with that agreement.

  3. Notes should always end with a full stop. Yours don't do that here.

@chrisdavidmills
Copy link
Contributor Author

OK, I've tried fixing this according to your comments, but the merge conflict fixing has turned it in a mess. I'm not sure if this is correct or not now.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this up and it should be good to go now 👍

@Elchi3 Elchi3 merged commit 0e4822f into mdn:master Nov 1, 2018
@chrisdavidmills chrisdavidmills deleted the storage-access-api branch November 1, 2018 11:19
@chrisdavidmills
Copy link
Contributor Author

Lovely, nice one @Elchi3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants