-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Storage Access API compat data #2990
Conversation
…ersion numbers to Fx 65, updating Safari support
The Firefox version data updates would be better in a separate PR. Also, we probably want to add some more future versions, so that we don't have to update this too frequently. I think last time we added like the next 5 Firefox releases. |
I appreciate that; I only added it here because I was worried that the data would error if it didn't have the versions in place. |
Done in #2995 |
OK, in that case I've removed the browser changes I added. |
This has failed because of the invalid version number thing. I take it this can be merged given that you added that stuff separately? |
Three things before this is good to go:
|
…ersion numbers to Fx 65, updating Safari support
OK, I've tried fixing this according to your comments, but the merge conflict fixing has turned it in a mess. I'm not sure if this is correct or not now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this up and it should be good to go now 👍
Lovely, nice one @Elchi3 ! |
As per https://trello.com/c/L48xh7RS/11-storage-access-api-fx-64