-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intrinsicsize
to HTML Media elements (img, video)
#2979
Conversation
Experimental `intrinsicsize` attribute added. Explainer: https://github.com/ojanvafai/intrinsicsize-attribute Chrome: `Experimental Web Platform features` flag, Version >= Chrome 71. https://www.chromestatus.com/feature/4704436815396864 Firefox: No public signals Edge: No public signals Safari: No public signals Web Developers: No signals
Add `intrinsicsize`
Oh yeah need to add browser versions... |
... can wait until full release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
... can wait until full release.
It's up to you of course, but I think we can update the Chrome browser list to include 71 now, since our list is out of date already (https://github.com/mdn/browser-compat-data/blob/master/browsers/chrome_android.json#L229-L234). (Is 71 the current Nightly? I'm not sure how things like Canary map to the definitions in browsers.json.) That would unblock this PR.
But it would probably be good to update the list of browsers in a separate PR.
A few comments on this PR:
- please keep subfeatures alphabetised
- I don't see any indication here https://www.chromestatus.com/feature/4704436815396864 or here https://github.com/ojanvafai/intrinsicsize-attribute that this is standard_track.
- the feature seems to be behind a flag, so you'll need to add something like this:
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
See for example https://github.com/mdn/browser-compat-data/blob/master/api/Request.json#L538-L545.
Understood, likely will do this evening. |
Two points. First, always use the anchor form rather than the string form of the flag. The explanation is here. @Elchi3 will be adding it to the linter. Second, this is behind the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've marked this as non-standard, inserted the features alphabetically, and fixed the flag information. Looks good to me now.
All comments addressed, thanks for your review!
Thank you, sorry about … completely forgetting |
Experimental
intrinsicsize
attribute added.Explainer: https://github.com/ojanvafai/intrinsicsize-attribute
Chrome:
Experimental Web Platform features
flag, Version >= Chrome 71. https://www.chromestatus.com/feature/4704436815396864Tested: no
Primarily done through manual
JSON.parse
andJSON.stringify
... may need changes forstandard_track
but not certain.