Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 133 + Safari TP support multiple import maps #25801

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jan 29, 2025

Summary

This PR adds a data point for multiple import maps support, which was documented by @yoavweiss in mdn/content#37739.

It has the following support:

Test results and supporting details

Spec PR: whatwg/html#10528

Related issues

@github-actions github-actions bot added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:m [PR only] 25-100 LoC changed labels Jan 29, 2025
@caugner caugner changed the title Chrome 133 and WebKit nightly support for multiple import maps Chrome 133 + WebKit nightly support multiple import maps Jan 30, 2025
@caugner caugner changed the title Chrome 133 + WebKit nightly support multiple import maps Chrome 133 + Safari TP support multiple import maps Jan 30, 2025
},
"multiple_import_maps": {
"__compat": {
"description": "Multiple import maps",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills Would you have a spec link, even if it's a Text Fragment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec URL added. I like the text fragment, as it links to an exact statement supporting it.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
"multiple_import_maps": {
"__compat": {
"description": "Multiple import maps",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner caugner merged commit 7dd96d6 into mdn:main Jan 31, 2025
7 checks passed
@caugner
Copy link
Contributor

caugner commented Jan 31, 2025

PS: We could also link to both the text fragment, and #merge-existing-and-new-import-maps. I merged anyways, because I didn't consider this open question a blocker, even if merging reduces the chances of us actually implementing that change.

@mdn-bot mdn-bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants