-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ff122 Element.checkVisibily options #21715
Ff122 Element.checkVisibily options #21715
Conversation
FWIW, Safari Technology Preview supports |
@Elchi3 What's the right way of indicating browser 184 - it appear to be an option in the browser stats yet (I presume that maps to 18.4?). Would I just mark as "preview"? Note, the changes appear to match spec - WebKit/WebKit@2d9a965 |
"184" refers to Safari Technology Preview v184, which does NOT map to 18.4 (we're not at that version number yet) -- "preview" is what we'd want to use here! |
Thanks, Safari added as Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hamishwillee 👍
Element.checkVisibility
has anoptions
object parameter. In the spec this has two options,checkOpacity
andcheckVisibilityCSS
, both of which are implemented AFAIK in Chrome (105) and Firefox (106) on first release of the method.The spec has an unmerged PR csswg-drafts#9549 to add three more options.
opacityProperty
andvisibilityProperty
are aliases for the original names with a new naming convention. The old names are not yet "deprecated" in the spec.contentVisibilityAuto
allows you to check if an element is being skipped for layout because it is not in the view.Even though the spec change hasn't merged, Chrome has implemented the change in 121 and Firefox has implemented it in nightly in FF122 (https://bugzilla.mozilla.org/show_bug.cgi?id=1859852).
standard
even though the spec change has not merged. You might argue that.Note that it is not entirely clear that the new options are preview in the web IDL, however you really can't test
contentVisibilityAuto
except in preview because the associated CSS is nightly only.My gut feeling is that all the options are actually "released", because I think the result of
checkVisibility()
is correct whether or not you are in preview (because it defaults false, and the feature isn't enabled results in false). I'm asking on the issue, but would appreciate your opinion - in which case we'd set FF release on these to 122?Other docs work for this can be tracked in mdn/content#31107
@Elchi3 @queengooborg If you are around and able, review appreciated. Mostly because I'm around on and off over January.