Add compat data for secure payment confirmation #21460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
|
Thank you so much, @wbamberg! I will have a look. |
|
LGTM, thanks! |
Elchi3
requested changes
Dec 8, 2023
There was a problem hiding this comment.
The data for
minPinLengthwas doing that usingmdn_urlbut that didn't work because fragments seem to get ignored there (?).
hm, the way minPinLength was doing that is the more consistent way in BCD. I would suggest you have mdn_url and description for all entries. That way caniuse will render:
"See full reference on MDN Web Docs."
If yari doesn't render the full url, then that's a bug in yari.
|
Ah, thanks for letting me know! I updated this PR and filed mdn/yari#10152. |
Elchi3
reviewed
Dec 8, 2023
Elchi3
reviewed
Dec 8, 2023
|
My sincere thanks to you all for helping get this done! |
You're welcome, and thanks for your patience with our pedantry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compat data for secure payment confirmation.
Supersedes #20583, using the same data as in that PR, but as additions to https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/create (for the WebAuth extension) and https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/PaymentRequest (for the new payment method.
I've also added links to docs for all the other WebAuth extensions. The data for
minPinLengthwas doing that usingmdn_urlbut that didn't work because fragments seem to get ignored there (?).