-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing closed/open CSS selector features #21369
Add missing closed/open CSS selector features #21369
Conversation
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `closed-and-open` CSS selector. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.5.1). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/selectors/closed-and-open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I think this is being removed. The CSS spec hasn't removed these two unfortunately. It was removed in the HTML spec: whatwg/html#9077
Gone in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1825807
Gone in Webkit: https://bugs.webkit.org/show_bug.cgi?id=254816
Chrome seems to not have removed :open and :closed and only added :popover-open?
https://bugs.chromium.org/p/chromium/issues/detail?id=1429670
I wonder if these should be marked at least deprecated or something? |
So I think there's still a desire to add I'm not sure how you'd like to represent this state in MDN! |
Thanks for the background, @mfreed7! (Shipping stuff this way is a bit bad for feature detection) |
Yeah, agreed. @josepharhar would you mind changing the code to only parse |
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing
closed
andopen
CSS selector. The data comes from the mdn-bcd-collector project (v10.5.1).Check out the collector's guide on how to review this PR.
Tests Used:
https://mdn-bcd-collector.gooborg.com/tests/css/selectors/open
https://mdn-bcd-collector.gooborg.com/tests/css/selectors/closed