Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing features for font-variant CSS property #21019

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

queengooborg
Copy link
Contributor

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing features of the font-variant CSS property. The data comes from the mdn-bcd-collector project (v10.2.9).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/font-variant

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing features of the `font-variant` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/font-variant
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 19, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm Chrome 111 with https://bugs.chromium.org/p/chromium/issues/detail?id=716567
Guessing it was Firefox 34 and Safari 9.1 per https://groups.google.com/a/chromium.org/g/blink-dev/c/IDXErld2g04/m/tJRD0Wu7CQAJ

Not sure if you meant to set Chrome 111 everywhere or if sub and super are 110...

css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
css/properties/font-variant.json Outdated Show resolved Hide resolved
@Elchi3 Elchi3 merged commit 25f7676 into mdn:main Oct 29, 2023
@queengooborg queengooborg deleted the css/properties/font-variant/additions branch October 29, 2023 16:49
Elchi3 added a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Add missing features for font-variant CSS property

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing features of the `font-variant` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/font-variant

* Apply suggestions from code review

Co-authored-by: Florian Scholz <[email protected]>

---------

Co-authored-by: Florian Scholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants