Add complete BCD for Window Management API #20600
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ | |
| }, | ||
| "availLeft": { | ||
| "__compat": { | ||
|
There was a problem hiding this comment. Why is this change necessary? @sideshowbarker has opinions about where to link in the specs. I think it has to do with where the MDN ribbon appears. There was a problem hiding this comment. The practice followed by the majority of the existing spec URLs is to use the URL for the developer part of the spec, if any. In this case, that’s https://w3c.github.io/window-management/#ref-for-dom-screendetailed-availleft And yeah the effect of that as far as the rendering of the published specs goes is that it causes the MDN annotation in the spec to be shown next the developer part of the spec (rather than the implementor part). There was a problem hiding this comment. OK, makes sense. I've reverted those changes, and added some other developer spec URLs |
||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-availleft", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -67,7 +67,7 @@ | |
| }, | ||
| "availTop": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-availtop", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -100,7 +100,7 @@ | |
| }, | ||
| "devicePixelRatio": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-devicepixelratio", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -133,7 +133,7 @@ | |
| }, | ||
| "isInternal": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-isinternal", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -166,7 +166,7 @@ | |
| }, | ||
| "isPrimary": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-isprimary", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -199,7 +199,7 @@ | |
| }, | ||
| "label": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-label", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -232,7 +232,7 @@ | |
| }, | ||
| "left": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-left", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -265,7 +265,7 @@ | |
| }, | ||
| "top": { | ||
| "__compat": { | ||
| "spec_url": "https://w3c.github.io/window-management/#dom-screendetailed-top", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "100" | ||
|
|
@@ -298,4 +298,4 @@ | |
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this change in your PRs and ignored it but then Vinyl opened #20560 so I think we do care about this. Please fix your editor config and don't change this from now on :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, I honestly never knew this was a thing to be concerned about! I have removed the odd newline here and there because I thought they were unnecessary.
I've updated my config so VSCode adds newlines to the end of all files on save, and added the missing ones into this PR. Sorted.