Add BCD for FedCM extensions #20547
Merged
Add BCD for FedCM extensions #20547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
Elchi3
reviewed
Aug 16, 2023
| } | ||
| } | ||
| }, | ||
| "loginHint": { |
There was a problem hiding this comment.
Isn't loginHint one level deeper even? Should it be providers?
dictionary IdentityCredentialRequestOptions {
sequence<IdentityProviderConfig> providers;
IdentityCredentialRequestOptionsContext context = "signin";
};
dictionary IdentityProviderConfig {
required USVString configURL;
required USVString clientId;
USVString nonce;
DOMString loginHint;
};There was a problem hiding this comment.
I know what you're getting at, but most of identity.providers has been supported for as long as identity.
I could perhaps update <code>context</code> option to <code>identity.context</code>, and <code>loginHint</code> option to <code>identity.providers.loginHint</code>, but that might not render very nicely. Thoughts?
There was a problem hiding this comment.
I think those descriptions would be helpful and I have seen longer ones, so I would go for it!
Elchi3
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 116 supports various Fed CM API extensions (see ChromeStatus entry)
See my research document for more details of what the extensions are.
Test results and supporting details
Related issues