Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add donkeycar manager front #109

Merged
merged 50 commits into from
Jul 3, 2022

Conversation

yannis-mlgrn
Copy link
Member

@yannis-mlgrn yannis-mlgrn commented Jun 2, 2022

✨ Features :

  • F1
  • F2
  • F3
  • F4
  • F5
  • F6 ( missing back ? , but a race is created when a car start running ?)
  • F7 ( missing back )
  • F8
  • F9
  • F10 ( missing back )
  • F11

see manager feature README

@yannis-mlgrn yannis-mlgrn requested a review from Benvii June 5, 2022 17:37
@yannis-mlgrn yannis-mlgrn marked this pull request as draft June 5, 2022 19:30
@yannis-mlgrn yannis-mlgrn marked this pull request as ready for review June 5, 2022 19:42
@yannis-mlgrn
Copy link
Member Author

Front seem good but I can't finish it due to missing features

@yannis-mlgrn yannis-mlgrn marked this pull request as draft June 19, 2022 19:38
@yannis-mlgrn yannis-mlgrn marked this pull request as ready for review June 19, 2022 19:50
@yannis-mlgrn
Copy link
Member Author

@Benvii It's done

@yannis-mlgrn
Copy link
Member Author

_vm.job1[0] is undefined why vm . Do you have an idea @Benvii ??

@yannis-mlgrn yannis-mlgrn force-pushed the 73-Create_donkeycar_manager_front branch from e18e1fa to 415c3df Compare June 21, 2022 21:12
@Benvii
Copy link
Member

Benvii commented Jun 21, 2022

Some remarks :

Fatal error :

  • Missing dependency : npm install --save vue-ins-progress-bar

Subscription :

  • for user subscription we need a big FAT pseudo input field clearly visible (from a color / contract) point of view, so that user can easily find it even if there is a lot of sun on the tablet .. big fields so that they can focus into it even with their fat fingers ^^
  • Fixed here : 44a6769
  • after subscription, "ok button" in the modal as a strange position, should be centered (as it's the only button) and maybe bigger
  • Fixed here : 44a6769
  • Why do I have 15min of waiting time, I'm the first player ? no one is in the queue .. we should remove it if the time is incorrect

Waiting board :

  • "éstimée" -> "Estimé"
  • Fixed here : 489c067
  • display dates dynamically take a look at what we have done in scratchy
  • Fixed here : 4400ab9

Dashboard :

  • For job ordering / ranking add and "up arrow" and "down arrow" to move up and down the job, logic behind these actions :
    • move up arrow : when clicked, loop into the job list, always save "job_before" until you reach clicked job, use job_before to call "move_before_job" with clicked job to put before job_before
    • Fixed here : 5ee2e20

Still need to perform more test on Dashboard

@yannis-mlgrn
Copy link
Member Author

yannis-mlgrn commented Jun 22, 2022

For increase the size, we should add vsSize argument in <vs-input> </vs-input>

They don't talk about it in their documentation, nice ^^. I have found the pull request who have added it in vuesax #274

don't works

we should maybe add this from scratch

@yannis-mlgrn
Copy link
Member Author

yannis-mlgrn commented Jun 22, 2022

BUG | problem with data update :

context : If we remove a player, we receive the ws, we update the player array but datas displaying aren't update ;(
update : It's maybe because we still have the CORS problem who fixed at #139

@Benvii
Copy link
Member

Benvii commented Jun 23, 2022

Client page :

  • Display car when worker is in state BUSY, worker when they run a job are always in BUSY state, that why I can't see anything

Register page :

  • modal "Ok" button still at a strange place and too small
  • can't register an existing player, we should be able to do so if someone wants to play again

dashboard :

  • Cars created doesn't show dynamically in the "cars" tab, is the event emitted ?

  • Cars > Settings : if clicked when no players and no job generate a lot of errors, see screenshot
    settingsWhenNoPlayersNoJob

  • Cars : stopped cars are displayed, their worker status is STOPPED

  • Cancel job fail see screenshot :
    cancelJobNotWorking

backend (so that we don't forget) :

  • swagger rely on CDN, doesn't work on isolated network, issue created [Backend] Offline swagger UI #146
  • postman doesn't work in isolated network --> Swagger UI will be sufficient

@yannis-mlgrn
Copy link
Member Author

courronne asset

this.cars = cars
for (const car of cars) {
if (car.current_stage !== 'MAINTENANCE' && car.worker.state === 'AVAILABLE') {
if (this.car1.length === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worker is busy when someone plays on it as a job is running

@Benvii Benvii merged commit ced3b9b into mdl29:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants