Add ref missing parameter in content endpoint
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palleas
changed the title
ref missing parameter in content ref missing parameter in content endpoint
mdiep
reviewed
Feb 5, 2017
Tentacle/Client.swift
Outdated
| return "/repos/\(owner)/\(repository)/contents/\(path)" | ||
| } | ||
| } | ||
|
|
||
| internal var queryItems: [URLQueryItem] { | ||
| return [] | ||
| switch self { | ||
| case let .content(_, _, _, ref): return [URLQueryItem(name: "ref", value: ref)] |
There was a problem hiding this comment.
Does this behave correctly if ref is nil?
Palleas
force-pushed
the
get-file-at-ref
branch
from
c7b5c7c to
6a43ed9
Compare
|
Rebased and Added some tests for the Endpoint enum. ✌🏼 |
Palleas
force-pushed
the
get-file-at-ref
branch
from
6a43ed9 to
0e0938f
Compare
ikesyo
reviewed
Feb 5, 2017
Sources/Tentacle/Client.swift
Outdated
| public func create(file: File, atPath path: String, in repository: Repository) -> SignalProducer<(Response, FileResponse), Error> { | ||
| return send(file, to: .content(owner: repository.owner, repository: repository.name, path: path), using: .put) | ||
| /// Create a file in a repository | ||
| public func create(file: File, atPath path: String, in repository: Repository, in branch: String? = nil) -> SignalProducer<(Response, FileResponse), Error> { |
There was a problem hiding this comment.
These new parameters above should follow the API Design Guidelines: https://swift.org/documentation/api-design-guidelines/
Compensate for weak type information to clarify a parameter’s role.
|
@ikesyo is it better now? I used |
mdiep
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API doesn't allow you to get a content at a specific ref and this fixes it.