fix: Crash on internal links trying to get supercharged

mdelobelle · Feb 5, 2022 · bd7fefb · bd7fefb
1 parent 54454ea
commit bd7fefb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "supercharged-links-obsidian",
 	"name": "Supercharged Links",
-	"version": "0.6.1",
+	"version": "0.6.2",
 	"minAppVersion": "0.12.7",
 	"description": "Adds properties and menu options to internal links",
 	"author": "mdelobelle",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "supercharged-links-obsidian",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "Adds properties and menu options to internal links",
   "main": "main.js",
   "scripts": {

diff --git a/src/linkAttributes/linkAttributes.ts b/src/linkAttributes/linkAttributes.ts
@@ -14,7 +14,7 @@ export function clearExtraAttributes(link: HTMLElement) {
 export function fetchTargetAttributesSync(app: App, settings: SuperchargedLinksSettings, dest: TFile, addDataHref: boolean): Record<string, string> {
     let new_props: Record<string, string> = { tags: "" }
     const cache = app.metadataCache.getFileCache(dest)
-    if (!cache) return;
+    if (!cache) return new_props;
 
     const frontmatter = cache.frontmatter
 
@@ -82,16 +82,16 @@ function setLinkNewProps(link: HTMLElement, new_props: Record<string, string>) {
         if (!newValue || curValue != newValue) {
             link.setAttribute("data-link-" + key, new_props[key])
         }
-        if (!link.hasClass("data-link-icon")) {
-            link.addClass("data-link-icon");
-        }
-        if (!link.hasClass("data-link-icon-after")) {
-            link.addClass("data-link-icon-after");
-        }
-        if (!link.hasClass("data-link-text")) {
-            link.addClass("data-link-text");
-        }
     });
+    if (!link.hasClass("data-link-icon")) {
+        link.addClass("data-link-icon");
+    }
+    if (!link.hasClass("data-link-icon-after")) {
+        link.addClass("data-link-icon-after");
+    }
+    if (!link.hasClass("data-link-text")) {
+        link.addClass("data-link-text");
+    }
 }
 
 function updateLinkExtraAttributes(app: App, settings: SuperchargedLinksSettings, link: HTMLElement, destName: string) {