Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user bg preference units #491

Merged
merged 1 commit into from
May 10, 2021

Conversation

yvon-dblg
Copy link
Contributor

No description provided.

@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch 2 times, most recently from 04f75d7 to 3345991 Compare April 23, 2021 17:09
@yvon-dblg yvon-dblg closed this Apr 23, 2021
@yvon-dblg yvon-dblg reopened this Apr 23, 2021
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from 3345991 to 80892e3 Compare April 23, 2021 17:17
@yvon-dblg yvon-dblg closed this Apr 23, 2021
@yvon-dblg yvon-dblg reopened this Apr 23, 2021
@yvon-dblg yvon-dblg requested a review from franck-fourel April 26, 2021 09:25
@yvon-dblg yvon-dblg force-pushed the fix/historic-links branch from b3ccb6c to bdd22cf Compare April 26, 2021 15:53
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from ab486f5 to 5b491df Compare April 26, 2021 15:55
Copy link
Contributor

@franck-fourel franck-fourel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question oon the npmrc file

.npmrc Show resolved Hide resolved
@yvon-dblg yvon-dblg force-pushed the fix/historic-links branch from bdd22cf to 0691c23 Compare April 29, 2021 16:20
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from 5b491df to 6db2931 Compare April 29, 2021 16:25
@yvon-dblg yvon-dblg force-pushed the fix/historic-links branch from 0691c23 to fb971cc Compare May 4, 2021 08:46
@yvon-dblg yvon-dblg requested a review from franck-fourel May 4, 2021 08:46
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from 6db2931 to dcf7cac Compare May 4, 2021 08:47
@yvon-dblg yvon-dblg force-pushed the fix/historic-links branch from fb971cc to aab98e8 Compare May 4, 2021 15:33
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from dcf7cac to 2c5cf6f Compare May 4, 2021 15:34
Copy link
Contributor

@franck-fourel franck-fourel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
works fine

@yvon-dblg yvon-dblg force-pushed the fix/historic-links branch from aab98e8 to 361924f Compare May 10, 2021 10:26
Base automatically changed from fix/historic-links to engineering/team-managment-v1 May 10, 2021 10:45
@yvon-dblg yvon-dblg force-pushed the feature/user-bgunits branch from 2c5cf6f to 485f9cc Compare May 10, 2021 10:46
@yvon-dblg yvon-dblg merged commit a3ddd2e into engineering/team-managment-v1 May 10, 2021
@yvon-dblg yvon-dblg deleted the feature/user-bgunits branch May 10, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants