Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement new star rating behavior #9

Merged
merged 1 commit into from
Oct 30, 2021
Merged

implement new star rating behavior #9

merged 1 commit into from
Oct 30, 2021

Conversation

JianShan-1214
Copy link
Member

No description provided.

fanlan1210
fanlan1210 approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@fanlan1210 fanlan1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起來是目前可行的方案，未來應再進一步將 rating.js 與 rating-star.js 整合。

@fanlan1210 fanlan1210 merged commit 3c8978c into mcuosc:main Oct 30, 2021
@JianShan-1214 JianShan-1214 deleted the starfix branch November 19, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanlan1210 fanlan1210 fanlan1210 approved these changes

@yihan5555 yihan5555 Awaiting requested review from yihan5555

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JianShan-1214 @fanlan1210