boot: zephyr: Fix sample.bootloader.mcuboot.usb_cdc_acm_recovery #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
reviewed
Nov 26, 2024
boot/zephyr/sample.yaml
Outdated
| @@ -19,7 +19,8 @@ tests: | |||
| sample.bootloader.mcuboot.usb_cdc_acm_recovery: | |||
| tags: bootloader_mcuboot | |||
| platform_allow: nrf52840dongle/nrf52840 | |||
| extra_args: DTC_OVERLAY_FILE="./usb_cdc_acm.overlay;app.overlay" | |||
| extra_args: EXTRA_CONF_FILE=./usb_cdc_acm_recovery.conf | |||
There was a problem hiding this comment.
Can this be replaced with - list, like the integration_platform below?
There was a problem hiding this comment.
Can this be replaced with - list, like the integration_platform below?
OK. Updated with the - list.
Adds missing usb_cdc_acm_recovery.conf configuration file for the sample.bootloader.mcuboot.usb_cdc_acm_recovery test case. Signed-off-by: Andrej Butok <[email protected]>
butok
force-pushed
the
fix_usb_cdc_acm_recovery
branch
from
cb8c06c
to
2b6f736
Compare
de-nordic
approved these changes
Nov 26, 2024
nordicjm
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing usb_cdc_acm_recovery.conf configuration file for the sample.bootloader.mcuboot.usb_cdc_acm_recovery test case.