Version compatibility updates to corrections.py #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new common.coffea file that is compatible with updates to coffea and uproot.
Updated to use uproot package from "import uproot" (uproot 4.7.3) rather than "import uproot3". Includes some corrections to how histograms that are loaded from uproot are read.
Open
Open
Remove the "test" prefix from the output coffea files generated by corrections.py and ids.py.
alejands
changed the title
Updated code obtained from jennetd/hbb-coffea repository on GitHub. https://github.com/jennetd/hbb-coffea/blob/master/boostedhiggs/corrections.py https://github.com/jennetd/hbb-coffea/blob/master/boostedhiggs/data/msdcorr.json Renamed the copied function to match convention used in decaf. Processor scripts were updated to use the new function, but still require other compatibility updates to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
corrections.pyto run with uproot package (version 4.7.3) instead of uproot3 package. Requiredcommon.pyto be rerun with new coffea version so the proper data types for newer coffea/uproot versions are saved.