Fixes #39: Adds support for encoding very small and very large integers #40
Conversation
The validation checks in v0.10 are different than in later versions of node, so we need to be explicit about converting the high dword to an integer
…e integers Integers smaller than Number.MIN_SAFE_INTEGER and larger than Number.MAX_SAFE_INTEGER are encoded as 8-byte floating point values
|
This builds on my previous pull request to support signed int 64s. If you'd prefer, this could be committed separately, but it would leave a gap in the signed integer encoding between the largest 32-bit integer and Number.MAX_SAFE_INTEGER which would fail. |
|
Well, I admit I hadn't noticed #38 when I posted #39. Thanks for your swift efforts, nevertheless! This fix will definitely suit people better than what we had before. Maybe in the future we could introduce some means of encoding and decoding 64-bit integers without losing precision, but for the moment this patch behaves in a much more predictable way. |
|
No problem, I actually had the same fix to address on my radar for today. Your issue report just gave me the encouragement to open it sooner. |
|
Superb! |
Fixes #39: Adds support for encoding very small and very large integers
No description provided.