Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adhere to padded-blocks #18

Merged
merged 1 commit into from
Aug 14, 2015
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Aug 14, 2015

We are in the process of adding back the rule padded-blocks into standard. It was temporarily disabled because of a bug in eslint which now has been fixed.

This pull request makes sure that your coding style is compliant with the new version.

Please see standard/standard#170 for more info.

@mcdonnelldean
Copy link
Contributor

Hey @LinusU Thanks a mill for the PR, I'll take a look at the build error, it's most likely on our end, I'll merge once I get that sorted. Again, Awesome work, thanks!

mcdonnelldean added a commit that referenced this pull request Aug 14, 2015
@mcdonnelldean mcdonnelldean merged commit d40bfbd into mcollina:master Aug 14, 2015
@mcdonnelldean
Copy link
Contributor

@LinusU Yup, on our end. I'll talk to @mcollina on our end about sorting that, either way This looks good and I'll keep an eye out for it happening again until Standard gets updated.

@LinusU
Copy link
Contributor Author

LinusU commented Aug 14, 2015

The build error is because leveldown doesn't work with iojs 3.0 which was recently released. This package is depending on level which in turn depends on leveldown. Since your travis yml specifies iojs it switched to 3.0 when it was released.

It was fixed yesterday in levldown master, they will probably cut a new release soon. Commit: ff8a40b

@LinusU
Copy link
Contributor Author

LinusU commented Aug 14, 2015

Nice, thank you for the quick pull! 🍻

@LinusU LinusU deleted the standard-style branch August 14, 2015 21:08
@mcdonnelldean
Copy link
Contributor

@LinusU No, thank you, see this is the sort of reason I love Standard. Yeah we have an outstanding PR about it on checking. As soon as that get's released we should be good. I've had a giggle though at the thought of a module breaking whitespace bug :D

This was referenced Aug 14, 2015
@mcollina
Copy link
Owner

Can we get this in a tune .travis.yml to not check on iojs-v3? This is possible. Leveldown 1.4.1 was released some days ago, so probably we should get that fixed anyway.

But, let's merge this.

@mcollina
Copy link
Owner

I have updated level and memdb, can you please get this in, @mcdonnelldean?

@LinusU
Copy link
Contributor Author

LinusU commented Aug 19, 2015

@mcollina Just so you know, this patch is already merged :) maybe you are referring to #20 thought?

@mcollina
Copy link
Owner

@LinusU this was reverted by @mcdonnelldean in #19

@LinusU
Copy link
Contributor Author

LinusU commented Aug 19, 2015

Aha, ehh, I don't understand why thought? You master branch is still failing on travis. Here is the report for the revert commit: https://travis-ci.org/mcollina/hyperemitter/builds/75677296

The problem isn't any code changes, it's just that travis upgraded their version of iojs to 3.0.

@mcdonnelldean
Copy link
Contributor

@LinusU I accidentally reverted, my bad, I then made another to reopen so I had a note for @mcollina. It's all good on your end 💃

@mcollina
Copy link
Owner

@mcdonnelldean just let me know when its's in so that I release a new version.

@mcdonnelldean
Copy link
Contributor

@mcollina Will do

@mcdonnelldean
Copy link
Contributor

Sorted as of #21

@mcdonnelldean
Copy link
Contributor

All reverts have been reverted too, @LinusU We are now marked as done again, sorry about that.

@LinusU
Copy link
Contributor Author

LinusU commented Aug 19, 2015

No problem, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants