Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid Maximum Stack exceeded error #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

normanzb
Copy link

@normanzb normanzb commented Oct 2, 2024

fixed #86

previous implementation of drained() increase stack usage of queue.drain() each time it was called, resulting Maximum Stack Exceeded error in a long running process.

previous implementation of `drained()` increase stack usage of `queue.drain()`
each time it was called, resulting Maximum Stack Exceeded error in a long running
process.
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Owner

mcollina commented Oct 4, 2024

Can you please fix support for legacy Node.js versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the implementation of drained() api potentially can cause maximum stack exceeded error
2 participants