Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision to specify urlSafe when idReplacement is true #320

Closed
zebkailash opened this issue Jan 12, 2021 · 1 comment · Fixed by #515
Closed

Provision to specify urlSafe when idReplacement is true #320

zebkailash opened this issue Jan 12, 2021 · 1 comment · Fixed by #515

Comments

@zebkailash
Copy link

If we want to add an id after an email string eg: [email protected] but currently there is no way to create a url-safe id.

Currently, it creates a string kailash-FZXY40aXS5C6Ph0KXs1KSQ/[email protected] which is an invalid email due to slash. Can this be supported in upcoming releases?
@mcollina
Copy link
Owner

Can this be supported in upcoming releases?

It will if you send a PR!

namerhila pushed a commit to namerhila/autocannon that referenced this issue May 5, 2021
@hilanamer
fix Provision to specify urlSafe when idReplacement is true mcollina#320
c047b37
@namerhila namerhila mentioned this issue May 5, 2021
Open
@10xLaCroixDrinker 10xLaCroixDrinker mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(requestIterator): generated IDs were not URL-safe
2 participants
@mcollina @zebkailash