Skip to content

Commit

Permalink
rework build_windows success logic
Browse files Browse the repository at this point in the history
  • Loading branch information
fraguada committed Sep 14, 2023
1 parent 75f2231 commit 22b1aa5
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions script/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,18 +211,20 @@ def build_windows():

run_command("cmake --build . --config Release --target librhino3dm_native", False)

if not build_did_succeed(item_to_check):
if not build_did_succeed(item_to_check):
return False

all_items_built = True
if not lib:
print(" Building Rhino3dm.dll...")
csproj_path = os.path.abspath(os.path.join(dotnet_folder, "Rhino3dm.csproj")).replace('\\', '//')
target_path = os.path.join(build_folder, platform_full_names.get("windows").lower())

command = 'dotnet build ' + csproj_path + ' /p:Configuration=Release'
rv = run_command(command)
all_items_built = rv == 0

return 0 # two target frameworks built, so just use the dotnet return value
return all_items_built # two target frameworks built, so just use the dotnet return value


def build_linux():
Expand Down

0 comments on commit 22b1aa5

Please sign in to comment.