Minor updates, removing useless bits and pieces.

classes/jobrunner.php

@@ -63,8 +63,6 @@ class qtype_coderunner_jobrunner {
      * this is a run triggered by the student clicking the Precheck button.
      * @param string $answerlanguage will be the empty string except for multilanguage questions,
      *      when it is the language selected in the language drop-down menu.
-     * @param boolean $validating Set to true if this is a validate on grading. Otherwise the
-     *      validate on save uses the qid of the last version.
      * @return qtype_coderunner_combinator_grader_outcome $testoutcome that contains the outcome
      *      of the grading.
      */

edit_coderunner_form.php

@@ -1630,8 +1630,7 @@ private function validate_sample_answer() {
             }
             [$mark, $state, $cachedata] = $this->formquestion->grade_response(
                 $response,
-                false, // Not a precheck.
-                false  // Don't use cache as it the old question id is used and would give old outcome.
+                false // Not a precheck.
             );
         } catch (Exception $e) {
             return $e->getMessage();

question.php

@@ -32,7 +32,7 @@
 use qtype_coderunner\constants;
 use qtype_coderunner\coderunner_files;
 
- /**
+/**
  * Represents a 'CodeRunner' question.
  */
 

tests/grader_test.php

@@ -63,11 +63,10 @@ public function test_regex_grader() {
     pass
 EOCODE;
         $response = ['answer' => $code];
-        // Moodle's test helper question uses an id of zero so turn off cache!
+        // Note: Moodle's test helper question always uses an id of zero!
         $result = $q->grade_response(
             $response,
             false, // Not a precheck.
-            false // Here usecache is set to false.
         );
         [$mark, $grade, $cache] = $result;
         $testoutcome = unserialize($cache['_testoutcome']); // For debugging test.
@@ -99,12 +98,11 @@ public function test_nearequality_grader_right_answer() {
     pass
 EOCODE;
         $response = ['answer' => $code];
-        // Moodle's test helper question uses an id of zero so turn off cache!
+        // Note: Moodle's test helper question always uses an id of zero!
         $result = $q->grade_response(
             $response,
             false, // Not a precheck.
-            false // Here usecache is set to false.
-          );
+        );
         [$mark, $grade, $cache] = $result;
         $testoutcome = unserialize($cache['_testoutcome']); // For debugging test.
         $this->assertEquals(1, $mark);
@@ -135,11 +133,10 @@ public function test_nearequality_grader_wrong_answer() {
     pass
 EOCODE;
         $response = ['answer' => $code];
-        // Moodle's test helper question uses an id of zero so turn off cache!
+        // Note: Moodle's test helper question always uses an id of zero!
         $result = $q->grade_response(
             $response,
             false, // Not a precheck.
-            false // Here usecache is set to false.
         );
         [$mark, $grade, $cache] = $result;
         $testoutcome = unserialize($cache['_testoutcome']); // For debugging test.

tests/template_test.php

@@ -111,20 +111,18 @@ public function test_grading_template() {
         $q->allornothing = false;
         $code = "def sqr(n): return n * n\n";
         $response = ['answer' => $code];
-        // Don't use cache as qid of zero is reused with different question!
+        // Note: qid of zero is reused with different question!
         $result = $q->grade_response(
             $response,
-            false, // Not a precheck.
-            false // Here usecache is set to false.
+            false // Not a precheck.
         );
         [$mark, $grade, $cache] = $result;
         $this->assertTrue(abs($mark - 24.0 / 31.0) < 0.000001);
         $q->allornothing = true;
-        // Don't use cache as qid of zero is reused with different question!
+        // Note: qid of zero is reused with different question!
         $result = $q->grade_response(
             $response,
-            false, // Not a precheck.
-            false // Here usecache is set to false.
+            false // Not a precheck.
         );
         [$mark, $grade, $cache] = $result;
         $this->assertTrue($mark == 0.0);