Handle multiple GestureDetector of ColorPicker #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a `ColorPicker` within a `ListView`, gestures are not always correctly assigned to the `ColorPicker`. Sometimes it is also assigned to the `ListView`, resulting in an unpleasant user experience. With the code changes, a `PanGestureRecognizer` is added to the `ColorPicker` that always wins, which fixes the problem.
|
Wow, that was fast! Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
ColorPickerwithin aListView, gestures are not alwayscorrectly assigned to the
ColorPicker. Sometimes it is also assignedto the
ListView, resulting in an unpleasant user experience.With the code changes, a
PanGestureRecognizeris added to theColorPickerthat always wins, which fixes the problem.