Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR broke a nice feature. #69

Closed
nikhilbadyal opened this issue Dec 6, 2021 · 1 comment
Closed

PR broke a nice feature. #69

nikhilbadyal opened this issue Dec 6, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@nikhilbadyal
Copy link

nikhilbadyal commented Dec 6, 2021

This the current status of block picker.(Video 1) As you can see when I change color on selecting new color. It doesn't show check mark on the newly selected color. ( Video recorded from the web page).

Luckily i had the old version of this package. And you can see how it used to work in older versions. (Video 2). Whenever i select new color. It shows i tick mark on that color.

I compared both the version and find out that the above commit broke this feature. Particularly this line

Link to commit

&& (widget.pickerColor.value == color.value),

Can you fix this ?

9rlISShDD8.mp4
video_2021-12-06_23-21-04.mp4
@nikhilbadyal nikhilbadyal changed the title PR broke a feature. PR broke a feature. [https://github.com/mchome/flutter_colorpicker/commit/9389d23d42cb7b67b39d3cb550f43c7fd9912ce9] Dec 6, 2021
@nikhilbadyal nikhilbadyal changed the title PR broke a feature. [https://github.com/mchome/flutter_colorpicker/commit/9389d23d42cb7b67b39d3cb550f43c7fd9912ce9] PR broke a nice feature. Dec 6, 2021
@mchome mchome added the bug Something isn't working label Dec 7, 2021
mchome added a commit that referenced this issue Dec 7, 2021
@mchome
Copy link
Owner

mchome commented Dec 12, 2021

Try v1.0.3.

@mchome mchome closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants