Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support terminator v2 #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yurenchen000
Copy link

@yurenchen000 yurenchen000 commented Nov 14, 2022

It's a great plugin.

but those days seems not compatible with terminator 2.x

  • open_in_current_term=True:

    • <=2.1.2: .feed() need bytes
    • >=2.1.3: .feed() need str
  • open_in_current_term=False:
    new editor will stuck terminator window

so, I made little adjust for working with terminator 2.x

Tested on ubuntu 22 lts,

  • terminator 2.1.1 (with python3.10)
  • terminator 2.1.3 (master branch, unreleased now) (with python3.10)

@shablipapu
Copy link

Hmm this plugin is not working for me. i'm guessing from this still open PR that this project is no longer maintained which is a shame. Perhaps @yurenchen000 you should fork the repo?

@shablipapu
Copy link

shablipapu commented Aug 8, 2023

also both the old version and the new version do not seem to work on ubuntu 20.04 in wsl2

@yurenchen000
Copy link
Author

yurenchen000 commented Aug 8, 2023

Hmm this plugin is not working for me. i'm guessing from this still open PR that this project is no longer maintained which is a shame. Perhaps @yurenchen000 you should fork the repo?

have you try this branch (which I patched for terminator v2.x) ?
https://github.com/yurenchen000/terminator-editor-plugin/tree/support_terminator_v2

@shablipapu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants