-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github actions to automatically run tests #16
base: main
Are you sure you want to change the base?
Conversation
227da0b
to
a0a27ca
Compare
a0a27ca
to
f395d8c
Compare
@asedeno this is great! I can see that https://github.com/asedeno/whoosh/actions/runs/943788205 runs clean. @mchaput this looks like a quick win to merge and have automatic feedback on testsuite runs on multiple python versions. |
If this gets merged, it should be followed up with an update to the python versions it tests with. I'd recommend removing 3.5 and 3.6, and adding 3.10 and 3.11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, it is only a bit behind meanwhile because this is rotting here since quite a while, so a few minor updates could be done before merging this.
Don't understand why this is not yet merged.
Having CI feedback for all supported python versions is pretty essential for a project.
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add 3.10 and 3.11 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9] | |
python-version: [3.8, 3.9, "3.10", 3.11, 3.12] |
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated to:
actions/checkout@v3
actions/setup-python@v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: actions/checkout@v2 | |
- name: Set up Python ${{ matrix.python-version }} | |
uses: actions/setup-python@v2 | |
- uses: actions/checkout@v4 | |
- name: Set up Python ${{ matrix.python-version }} | |
uses: actions/setup-python@v5 |
pip install pytest nose coverage cached-property | ||
python setup.py clean build install | ||
- name: Run test | ||
run: nosetests --with-coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is different from what tox.ini
is using. Which way is better?
pip install pytest nose coverage cached-property | ||
python setup.py clean build install | ||
- name: Run test | ||
run: nosetests --with-coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install pytest nose coverage cached-property | |
python setup.py clean build install | |
- name: Run test | |
run: nosetests --with-coverage | |
pip install pytest pytest-cov coverage cached-property | |
python setup.py clean build install | |
- name: Run test | |
run: pytest |
nose
stopped working around Python 3.8.
Correct FP rounding errors
No description provided.