Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github actions to automatically run tests #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asedeno
Copy link

@asedeno asedeno commented Jun 16, 2021

No description provided.

@asedeno asedeno force-pushed the git-workflow-testing branch from 227da0b to a0a27ca Compare June 16, 2021 14:26
@asedeno asedeno changed the title Use git workflows to automatically run tests Use github actions to automatically run tests Jun 16, 2021
@asedeno asedeno force-pushed the git-workflow-testing branch from a0a27ca to f395d8c Compare June 16, 2021 17:54
@clach04
Copy link

clach04 commented Apr 8, 2023

@asedeno this is great! I can see that https://github.com/asedeno/whoosh/actions/runs/943788205 runs clean.

@mchaput this looks like a quick win to merge and have automatic feedback on testsuite runs on multiple python versions.

@asedeno
Copy link
Author

asedeno commented Apr 8, 2023

If this gets merged, it should be followed up with an update to the python versions it tests with. I'd recommend removing 3.5 and 3.6, and adding 3.10 and 3.11.

Copy link

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, it is only a bit behind meanwhile because this is rotting here since quite a while, so a few minor updates could be done before merging this.

Don't understand why this is not yet merged.
Having CI feedback for all supported python versions is pretty essential for a project.

runs-on: ubuntu-latest
strategy:
matrix:
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add 3.10 and 3.11 here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9]
python-version: [3.8, 3.9, "3.10", 3.11, 3.12]

Comment on lines +13 to +15
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated to:

actions/checkout@v3
actions/setup-python@v4

Copy link

@cclauss cclauss Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5

pip install pytest nose coverage cached-property
python setup.py clean build install
- name: Run test
run: nosetests --with-coverage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is different from what tox.ini is using. Which way is better?

Comment on lines +21 to +24
pip install pytest nose coverage cached-property
python setup.py clean build install
- name: Run test
run: nosetests --with-coverage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install pytest nose coverage cached-property
python setup.py clean build install
- name: Run test
run: nosetests --with-coverage
pip install pytest pytest-cov coverage cached-property
python setup.py clean build install
- name: Run test
run: pytest

nose stopped working around Python 3.8.

cclauss pushed a commit to cclauss/whoosh-1 that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants