Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move draw utils from AbstractRenderHelper to Render class #89

Open
mcgivrer opened this issue Nov 25, 2021 · 0 comments
Open

Move draw utils from AbstractRenderHelper to Render class #89

mcgivrer opened this issue Nov 25, 2021 · 0 comments
Assignees
@mcgivrer
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Milestone
1.0.2

Comments

@mcgivrer
Copy link
Owner

Modify the Render to propose all the drawing API from AbstractRenderHelper, and modify all RenderHelper implementations to delegate to Render all drawing operations, and no more to AbstractRenderHelper.

Change all RenderHelper signatures to remove Graphics2D and propose the Render instead.
@mcgivrer mcgivrer added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 25, 2021
@mcgivrer mcgivrer added this to the 1.0.1 milestone Nov 25, 2021
@mcgivrer mcgivrer self-assigned this Nov 25, 2021
@mcgivrer mcgivrer modified the milestones: 1.0.1, 1.0.2 Nov 29, 2021
@mcgivrer mcgivrer mentioned this issue Dec 15, 2021
Closed
@mcgivrer mcgivrer linked a pull request Dec 15, 2021 that will close this issue
Feature/render api simplification #125
Closed
mcgivrer added a commit that referenced this issue Dec 15, 2021
@mcgivrer
feat(refactor): Refactor and simplify Render API
2640a1b 
- modify Render to remove Graphice2d fomr every signature method
- update chapter 21 about enhancing rendering pipeline to take in
  account this change

fix #89,#125
@mcgivrer mcgivrer added the good first issue Good for newcomers label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcgivrer mcgivrer

Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

Feature/render api simplification mcgivrer/fromClassToGame
1 participant
@mcgivrer