feat(UpgradeConfig): Move confiig to a CLI parser system

- Fix some codacy identified issues. fix #61
mcgivrer · Oct 13, 2021 · adbe8cf · adbe8cf
1 parent 61770c7
commit adbe8cf
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 32 deletions.
diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/Configuration.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/Configuration.java
@@ -28,7 +28,7 @@ public class Configuration {
 
     public Configuration(String configurationPath) {
 
-        cm = new CliManager(null);
+        cm = new CliManager();
         defaultConfig = ResourceBundle.getBundle(configurationPath);
         initializeArgParser();
         readValuesFromFile();

diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/ArgParser.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/ArgParser.java
@@ -22,7 +22,5 @@ public interface ArgParser<T> {
 
     public T getDefaultValue();
 
-    public void parseFromConfigFile(String line);
-
     public String getConfigKey();
 }
diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/CliManager.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/CliManager.java
@@ -14,14 +14,11 @@
 import java.util.ResourceBundle;
 
 public class CliManager {
-    @SuppressWarnings("unused")
-    private Game game;
     private Map<String, ArgParser<?>> argParsers = new HashMap<>();
     private Map<String, ArgParser<?>> configParsers = new HashMap<>();
     private Map<String, Object> values = new HashMap<>();
 
-    public CliManager(Game g) {
-        this.game = g;
+    public CliManager() {
     }
 
     public void add(ArgParser<?> ap) {

diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/DoubleArgParser.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/DoubleArgParser.java
@@ -8,7 +8,7 @@
 public class DoubleArgParser extends AbstractArgParser<Double> {
 
     public DoubleArgParser(String name, String shortKey, String longKey, String description, String configKey,
-            Double defaultValue) {
+                           Double defaultValue) {
         super(name, description, shortKey, longKey, configKey);
         setDefaultValue(defaultValue);
     }
@@ -33,11 +33,4 @@ public Double parse(String strValue) {
         Double i = Double.parseDouble(strValue);
         return i;
     }
-
-    @Override
-    public void parseFromConfigFile(String line) {
-        // TODO Auto-generated method stub
-
-    }
-
 }
diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/IntegerArgParser.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/IntegerArgParser.java
@@ -35,10 +35,4 @@ public Integer parse(String strValue) {
         int value = Integer.parseInt(strValue);
         return value;
     }
-
-    @Override
-    public void parseFromConfigFile(String line) {
-
-    }
-
 }
diff --git a/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/StringArgParser.java b/src/main/java/fr/snapgames/fromclasstogame/core/config/cli/StringArgParser.java
@@ -11,13 +11,6 @@ public StringArgParser(String name, String description, String shortKey, String
         setDefaultValue(defaultValue);
     }
 
-    @Override
-    public void parseFromConfigFile(String line) {
-        // TODO Auto-generated method stub
-
-    }
-
-
     @Override
     public boolean validate(String strValue) {
         Optional<String> valueMightBeNull = Optional.of(strValue);

diff --git a/...java/fr/snapgames/fromclasstogame/core/config/cli/exception/ArgumentUnknownException.java b/...java/fr/snapgames/fromclasstogame/core/config/cli/exception/ArgumentUnknownException.java
@@ -6,11 +6,7 @@
 package fr.snapgames.fromclasstogame.core.config.cli.exception;
 
 public class ArgumentUnknownException extends Exception {
-
     public ArgumentUnknownException(String string, String key) {
         super(String.format(string, key));
     }
-
-    private static final long serialVersionUID = 1L;
-
 }