Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #191: missing return value, thx @surfermarty #192

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Fix #191: missing return value, thx @surfermarty #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1604ec3
Fix #191: missing return value, thx @surfermarty
terrillmoore Jun 6, 2022
acb1dd9
Update docs, make this 0.9.2-pre1
terrillmoore Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 25 additions & 21 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,28 @@
- [Overview](#overview)
- [Required libraries](#required-libraries)
- [Compile-time Configuration](#compile-time-configuration)
- [Region Selection](#region-selection)
- [Network selection](#network-selection)
- [Join Subband Selection](#join-subband-selection)
- [Region Selection](#region-selection)
- [Network selection](#network-selection)
- [Join Subband Selection](#join-subband-selection)
- [Writing Code With This Library](#writing-code-with-this-library)
- [Using the LMIC's pre-configured pin-maps](#using-the-lmics-pre-configured-pin-maps)
- [Supplying a pin-map](#supplying-a-pin-map)
- [Details on use](#details-on-use)
- [Using the LMIC's pre-configured pin-maps](#using-the-lmics-pre-configured-pin-maps)
- [Supplying a pin-map](#supplying-a-pin-map)
- [Details on use](#details-on-use)
- [APIs](#apis)
- [Starting operation](#starting-operation)
- [Poll and update the LMIC](#poll-and-update-the-lmic)
- [Reset the LMIC](#reset-the-lmic)
- [Shut down the LMIC](#shut-down-the-lmic)
- [Register an event listener](#register-an-event-listener)
- [Send an event to all listeners](#send-an-event-to-all-listeners)
- [Manipulate the Debug Mask](#manipulate-the-debug-mask)
- [Output a formatted log message](#output-a-formatted-log-message)
- [Get the configured LoRaWAN region, country code, and network name](#get-the-configured-lorawan-region-country-code-and-network-name)
- [Set link-check mode](#set-link-check-mode)
- [Send a buffer](#send-a-buffer)
- [Register a Receive-Buffer Callback](#register-a-receive-buffer-callback)
- [Get DevEUI, AppEUI, AppKey](#get-deveui-appeui-appkey)
- [Test provisioning state](#test-provisioning-state)
- [Starting operation](#starting-operation)
- [Poll and update the LMIC](#poll-and-update-the-lmic)
- [Reset the LMIC](#reset-the-lmic)
- [Shut down the LMIC](#shut-down-the-lmic)
- [Register an event listener](#register-an-event-listener)
- [Send an event to all listeners](#send-an-event-to-all-listeners)
- [Manipulate the Debug Mask](#manipulate-the-debug-mask)
- [Output a formatted log message](#output-a-formatted-log-message)
- [Get the configured LoRaWAN region, country code, and network name](#get-the-configured-lorawan-region-country-code-and-network-name)
- [Set link-check mode](#set-link-check-mode)
- [Send a buffer](#send-a-buffer)
- [Register a Receive-Buffer Callback](#register-a-receive-buffer-callback)
- [Get DevEUI, AppEUI, AppKey](#get-deveui-appeui-appkey)
- [Test provisioning state](#test-provisioning-state)
- [Examples](#examples)
- [Release History](#release-history)
- [Notes](#notes)
Expand Down Expand Up @@ -424,10 +424,14 @@ However, [examples/simple_sensor_bme280](examples/simple_sensor_bme280/simple_se

**Note**: the example uses the MCCI fork of the Adafruit BME280 library, found [here](https://github.com/mcci-catena/Adafruit_BME280_Library). This won't trouble you unless you actually try to use the code, rather than replacing the sensor logic with your own logic.

Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](https://github.com/mcci-catena/Catena-Arduino-Platform) library; but that library is so large that it's tough to figure out what's required for LoRaWAN, and what's used for supporting our boards.
Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](https://github.com/mcci-catena/Catena-Arduino-Platform) library; but that library is so large that it's tough to figure out what's required for LoRaWAN, and what's used for supporting MCCI boards.

## Release History

- Head includes the following changes.

- Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/169)). This is v0.9.2-pre1.

- v0.9.1 includes the following changes.

- Check size and tag of SessionChannelMask when restoring a session ([#169](https://github.com/mcci-catena/arduino-lorawan/issues/169)).
Expand Down
2 changes: 1 addition & 1 deletion src/Arduino_LoRaWAN.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Copyright notice:
/// \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions.
///
#define ARDUINO_LORAWAN_VERSION \
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 1, 0) /* v0.9.1 */
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 1) /* v0.9.2-pre1 */

#define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v) \
(((v) >> 24u) & 0xFFu)
Expand Down
2 changes: 2 additions & 0 deletions src/lib/arduino_lorawan_cEventLog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ Arduino_LoRaWAN::cEventLog::processSingleEvent()
{
m_head = 0;
}

return true;
}

void
Expand Down