Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.0 - sx1272 - line misspelled #537

Merged
merged 2 commits into from
Feb 14, 2020
Merged

v3.1.0 - sx1272 - line misspelled #537

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4fc9cd
v3.1.0 - sx1272 - line misspelled
ricaun Feb 11, 2020
4551a75
Update radio.c
ricaun Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lmic/radio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ static void configLoraModem () {

// set ModemConfig2 (sf, AgcAutoOn=1 SymbTimeoutHi)
u1_t mc2;
mc2 = (SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3));
mc2 = ((SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I wonder how this got through CI testing, as I thought I was compiling for SX1272.

This will work, but I think it's more matching the rest of the style to remove the extra ) at the end of the line, i.e.:

mc2 = (SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3);

The intent is to compute a | b | c; the extra parens make it harder to read.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I put an extra ( instead of deleting the ) 😄


#if CFG_TxContinuousMode
// Only for testing
Expand Down