Add HalConfiguration TTGO_LoRa32_V1 #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addition makes sense. However, the same addition is already in branch issue453 (see https://github.com/mcci-catena/arduino-lmic/blob/issue453/src/hal/getpinmap_thisboard.cpp). It's probably wiser to soon merge the branch into master than to merge this pull request. |
|
Sorry all, it's been a crazy few weeks. It looks like I should merge issue453 over the next ten days. I just need to re-address #442. |
|
looks like the latest changes broke this pr. i’ll take a look in in the next few days, or feel free to update. it’s possible that an equivalent change was applied in the latest big merge. |
|
is no longer needed, since this was implemented via another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @terrillmoore
the HAL configuration already defined, but was not used in getpinmap_thisboard.
Regards
Alex